I noticed you have committed changes to "branches/7.0" to add support for VCL build mode — great! Thanks for your contributions!
I have updated the log messages to refer to [feature-requests:#70] "Support for the Clang-based Embarcadero compilers". And I have improved the log messages to better describe the changes made. See "branches/7.0".
Note that you accidentally introduced tab characters for indentation in [r6264], messing up the code formatting. I have fixed this in [r6267]. Tip: Review your changes (using the TortoiseSVN tools, or your diff-viewer of choice) before committing them.
Since your revisions make changes to code on a release branch, I have updated the version number of the branch to 7.0.10 and set OWL_PRERELEASE to 1, to signal that the release branch is now dirty. This is important to avoid version conflicts, for users that download the library from the branch.
If you plan to commit further work, please commit your changes to the trunk, not the release branches. The release branches are public, and they are referred to in our installation guide, and as such should ideally contain pristine released versions of the code, without unreleased changes. Then when we are ready for release, the release manager (usually me now) will merge selected changes to the release branches in preparation for release.
Don't leave your signature in the code. The author of changes to the code is recorded by Subversion, so signatures just add clutter that often gets out of date. The same goes for code comments about changes to the code; these comments belong in the revision log message. Only add code comments to describe what is going on in the current code, if necessary.
For guidance on these matters and more, see our Coding Standards.
Again, thanks for your contributions, and don't let my comments make you hesitate to commit further changes as you see fit. I am happy to see more contributors working on the code. I'm just doing normal code review and nit-picking. :-)
PS: I have now merged your revisions [r6263]-[r6265] into the trunk [r6271]. I have also documented your work in [feature-requests:#70], by linking to the code revisions. Please do so as well, if you make further changes.
Hi @luigibianchi,
I noticed you have committed changes to "branches/7.0" to add support for VCL build mode — great! Thanks for your contributions!
I have updated the log messages to refer to [feature-requests:#70] "Support for the Clang-based Embarcadero compilers". And I have improved the log messages to better describe the changes made. See "branches/7.0".
Note that you accidentally introduced tab characters for indentation in [r6264], messing up the code formatting. I have fixed this in [r6267]. Tip: Review your changes (using the TortoiseSVN tools, or your diff-viewer of choice) before committing them.
Since your revisions make changes to code on a release branch, I have updated the version number of the branch to 7.0.10 and set OWL_PRERELEASE to 1, to signal that the release branch is now dirty. This is important to avoid version conflicts, for users that download the library from the branch.
If you plan to commit further work, please commit your changes to the trunk, not the release branches. The release branches are public, and they are referred to in our installation guide, and as such should ideally contain pristine released versions of the code, without unreleased changes. Then when we are ready for release, the release manager (usually me now) will merge selected changes to the release branches in preparation for release.
Don't leave your signature in the code. The author of changes to the code is recorded by Subversion, so signatures just add clutter that often gets out of date. The same goes for code comments about changes to the code; these comments belong in the revision log message. Only add code comments to describe what is going on in the current code, if necessary.
For guidance on these matters and more, see our Coding Standards.
Again, thanks for your contributions, and don't let my comments make you hesitate to commit further changes as you see fit. I am happy to see more contributors working on the code. I'm just doing normal code review and nit-picking. :-)
PS: I have now merged your revisions [r6263]-[r6265] into the trunk [r6271]. I have also documented your work in [feature-requests:#70], by linking to the code revisions. Please do so as well, if you make further changes.
Related
Commit: [r6263]
Commit: [r6264]
Commit: [r6265]
Commit: [r6267]
Commit: [r6271]
Feature Requests: #70
Last edit: Vidar Hasfjord 2023-01-07