TColorList in CoolPrj does not display colors
Borland's Object Windows Library for the modern age
Brought to you by:
jogybl,
sebas_ledesma
Fixed on trunk in [r7134].
Related
Commit: [r7134]
Last edit: Ognyan Chernokozhev 2024-10-07
I wonder if the fix should be merged back to 6.44 and 7.0. On one hand, it changes the parent class for TColorList and adds a protected method overried. On the other hand, I double that there is any user code that relies on this class in CoolPrj that may break, as it was non-functional.
Just until recently I wasnt able to use the CoolPrj in Embarcadero C++. so for me it's ok to include the fix in 6.44 / 7.
The original idea of the color list painting is now hooked up.
A possible future enhancement is to utilize the new Named colors in OWLNext, so that the color list draws both the color and its name.
Good work! I can confirm that the colours now show in the "Syntax Highlighting" dialog in the debug version of OWLMaker (and presumaby in the release version as well, even though I haven't tested that yet).
However, they just show as a seemingly random unsorted list of colours. Ordering by hue may have made it more useful as is, but even better, since this is presumably a list of named colours, providing the names would make more sense of it.
Also, there should be a "Custom" option that opens the common colour dialog (using the current active colour as the initial setting).
Personally, I would prefer not to make incompatible changes to the LTS releases unless there is urgent demand. If you want it in the current production series, we should at least go to 7.1, to indicate that recompilation is required (and in terms of full SemVer compliance, we should go to 8, since in theory, the change can cause compilation errors in client code).
I'll leave it to you to decide. However, if you decide LTS releases should be updated, then don't merge yet, unless you intend to make an imminent release. Just set the ticket milestone as appropriate and the state to "pending". Then we'll merge in preparation for release when the time comes. This way we keep release branches clean.
PS. Regarding the "Syntax Highlighting" dialog, it has further problems in that the font changes makes no sense (font and size should only be enabled for "Normal" text, since it has to be the same for all categories) or font changes have no effect (changing the font makes no difference, unless bold or italic is enabled, in which case the font width may change and mess up the rendering). But this is for another ticket.
This issue seems to have been resolved, so I have set the ticet status to "pending". For more information about the fixes and improvements to the Syntax Highlighting dialog, see [feature-requests:#252].
Please review and test.
Related
Feature Requests: #252