Menu

#501 BOleFont::Invoke fails to evaluate correctly wFlags

8
open
BOCOLE (2)
1
2022-12-29
2021-06-26
No

BOleFont::Invoke lacks the needed parentheses, same as BOlePicture::Invoke [bugs:#500].

  if ( !(wFlags & DISPATCH_PROPERTYGET|DISPATCH_PROPERTYPUT))
    return ResultFromScode(E_INVALIDARG);

The correct expression is:

  if ( !(wFlags & (DISPATCH_PROPERTYGET|DISPATCH_PROPERTYPUT)))
    return ResultFromScode(E_INVALIDARG);

Related

Bugs: #500
Feature Requests: #184
Wiki: OWLNext_Roadmap_and_Prereleases

Discussion

  • Vidar Hasfjord

    Vidar Hasfjord - 2021-06-26
    • labels: --> BOCOLE
    • Description has changed: Added links to [bugs:#500] and source code.
     

    Related

    Bugs: #500


    Last edit: Vidar Hasfjord 2021-06-26
  • Vidar Hasfjord

    Vidar Hasfjord - 2021-06-26

    This issue was fixed in [r5533] on the 6.44 branch.

    TODO: This fix should be merged to the trunk and to the 7.0 branch, as well. Then post a comment here, documenting the completion of the fix, and set the ticket status to "pending" for review and release.

     

    Related

    Commit: [r5533]

  • Vidar Hasfjord

    Vidar Hasfjord - 2021-09-09

    This fix has now been merged to the trunk in [r5581] and temporarily undone on the 6.44 branch [r5584]. When the current work on BOCOLE is complete, the fix should be merged to the relevant supported release branches (currently 6.44 and 7.0), and this ticket status should be set to "pending" for review and release.

     

    Related

    Commit: [r5581]
    Commit: [r5584]

  • Vidar Hasfjord

    Vidar Hasfjord - 2022-02-05
    • Group: 6.44 --> 7.1
     

Log in to post a comment.

MongoDB Logo MongoDB