Menu

#350 TXOle::Clone hides virtual function (regression in 6.34/6.35)

unspecified
wont-fix
nobody
1
2026-04-03
2016-09-19
No

In the Exception Transport Review [r1770], as part of fixing [bugs:#230], owl::TXBase::Clone was made const on the 6.34 branch. In OCFNext, ocf::TXOle inherits owl::TXBase, but it was not updated, thus rendering its intended override of Clone dysfunctional.

Note that in OWLNext 6.40 and later, this issue does not apply, since TXBase::Clone is not const in these versions. It remains non-const as in the original OWL 5. This is because [r1770] was only applied to the 6.34 branch, and not to 6.40 and later versions.

Proposed solution: Make TXBase::Clone non-const again for 6.36, as in the original OWL 5, and deprecate it and relegate it to OWL5_COMPAT mode (or remove it altogether) on the trunk, where it is no longer used (exception transport is now implemented using std::exception_ptr).

Related

Bugs: #230
Commit: [r1770]
Discussion: 2d1cefe9
Discussion: TXOle::Clone hides virtual function (regression in 6.34/6.35) [bugs:#350]

Discussion

  • Vidar Hasfjord

    Vidar Hasfjord - 2018-05-04
    • labels: OCF --> OCF, API
    • status: open --> wont-fix
     
  • Vidar Hasfjord

    Vidar Hasfjord - 2018-05-04

    This issue does not apply to supported version of OWLNext, so I have closed it as "wont-fix".

     
  • Vidar Hasfjord

    Vidar Hasfjord - 2026-04-03
    • labels: OCF, API --> OCF, API, Regression
     

Log in to post a comment.

MongoDB Logo MongoDB