Menu

#301 Removing the last TDockableControlBar from the upper harbor crashes

6.40.6
closed
olaf
Crash (79)
1
2015-04-19
2015-02-13
olaf
No

Moving a top docked TDockableControlBar to the middle of the MainWindow, if you do this the application will crash (e.g. "OWLMaker.exe"). This is because in TEdgeSlip::CompressGridLines the line

:::C++ 
      CHECK(!decoList.empty());


should be replaced by

:::C++
      if (!decoList.empty()) {


and a closing brace before

:::C++
      ReLayout(false);


Reason: The decoList is temporarily empty, if you remove the last TControlBar from the upper harbor.

Related

Discussion: Call for developers
Wiki: OWLNext_Stable_Releases

Discussion

  • Vidar Hasfjord

    Vidar Hasfjord - 2015-03-04

    Hi Olaf,

    Thanks for reporting this bug. I have added you to the list of developers so that you can take ownership of the ticket. To get started, see the wiki page "Contributing to the OWLNext Project".

     

    Related

    Discussion: c8848884
    Wiki: Contributing

    • olaf

      olaf - 2015-03-11

      Hi Vidar,

      I checked out the OWLNext-Project with Tortoise SVN via https and svn+ssh. Committing the changes in the https checked out tree results in an error:

      could not begin a transaction
      


      Committing changes in the svn+ssh checked out tree produces the error:

      Can't open file '/svn/p/owlnext/code/db/txn-current-lock': Permission denied
      


      Can you help me?

      Olaf.

      Moderator: Formatted messages, removed quoted content.

       

      Last edit: Vidar Hasfjord 2015-03-11
  • Vidar Hasfjord

    Vidar Hasfjord - 2015-03-11

    Committing the changes [using https] results in an error

    Sorry, I added the wrong olaf to the Developer list. I have rectified my error, so you should now have permission. Please try again.

     
  • olaf

    olaf - 2015-03-11
    • assigned_to: olaf
    • status: open --> closed

    Thanks Vidar,

    I commited the change.

    Prior I compiled OWL via OWLMaker. All Ok. Then I compiled OWLMaker. Movement of the TDockableControlBar is now possible.

     

    Last edit: Vidar Hasfjord 2015-03-11
  • Vidar Hasfjord

    Vidar Hasfjord - 2015-03-11
    • status: closed --> pending
    • group: unspecified --> 6.40.6

    Hi Olaf,

    I commited the change.

    Great, congratulations on your first commit!

    Movement of the TDockableControlBar is now possible

    Good work.

    Tip: After checking in a solution, please include a reference to the revision implementing your fix, e.g. "This issue has been fixed [r3000]". And set the status to "pending" until the fix has been released (i.e. the associated milestone is completed).

     

    Related

    Commit: [r3000]


    Last edit: Vidar Hasfjord 2015-03-11
  • Vidar Hasfjord

    Vidar Hasfjord - 2015-04-16
    • labels: --> Crash
    • summary: Removing the last TDockableControlBar from the upper harbor --> Removing the last TDockableControlBar from the upper harbor crashes
     
  • Vidar Hasfjord

    Vidar Hasfjord - 2015-04-19
    • Status: pending --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB