Menu

#237 Unintended TColor constructor selection and conversions

6.34
closed
API (62)
1
2014-03-06
2013-02-27
No

Due to the many overloaded implicit TColor constructors, it is easy for overload resolution to select an unintended overload and to do unintended implicit conversions.

For example, our recent change in OWLNext of the implicit TColor (long) constructor to explicit TColor (LRESULT) became a silent breaking change for this reason, since the overload resolution redirected earlier implicit conversions, that previously resolved to this constructor, to the TColor (int) constructor instead. For more about this issue, see [discussion:0cb40903] started by Erwin Lotter.

Related

Discussion: 0cb40903
Discussion: owlext and TColor(int) / TColor(long)
Wiki: 64-bit_OWLNext
Wiki: Frequently_Asked_Questions

Discussion

  • Vidar Hasfjord

    Vidar Hasfjord - 2013-02-27

    There are some bugs in OWLExt related to this issue. See [discussion:6b7618b6].

    I have applied Erwin Lotter's patches for these bugs in [r1793].

     

    Related

    Commit: [r1793]
    Discussion: 6b7618b6

  • Vidar Hasfjord

    Vidar Hasfjord - 2013-03-01

    A fix for this issue was implemented in [r1800].

     

    Related

    Commit: [r1800]

  • Vidar Hasfjord

    Vidar Hasfjord - 2013-03-01
    • status: open --> pending
     
  • Vidar Hasfjord

    Vidar Hasfjord - 2014-03-06
    • Status: pending --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB