[OPT-general] [ outreach-Bugs-795344 ] sql errors (syntax)

[SourceForge.net <no...@so...>]

Bugs item #795344, was opened at 2003-08-26 13:19
Message generated for change (Comment added) made by guy_davis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=410239&aid=795344&group_id=34206

Category: None
>Group: OPT 1.X (Max)
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Guy Davis (guy_davis)
Summary: sql errors (syntax)

Initial Comment:
This is a two part bug: 
 
1) 
in include/general.php 
function getvalue 
[...] 
$result=CRM_run_query($sql); 
      if ($result) { 
        if (OPT_num_rows($result)) { 
          $myrow=OPT_fetch_row($result); 
          if (!is_array($value)) { 
            $myrow=$myrow[0]; 
          } 
          return($myrow); 
        } 
      } else { 
         return($ifnull); 
      } 
 
[...] 
The problem is that if $result is true BUT there is 
no row returned (it's possible!) nothing is returned. 
idea for correct it: 
[...] 
$result=CRM_run_query($sql); 
      if ($result) { 
        if (OPT_num_rows($result)) { 
          $myrow=OPT_fetch_row($result); 
          if (!is_array($value)) { 
            $myrow=$myrow[0]; 
          } 
          return($myrow); 
        } 
         return($ifnull); 
[...] 
In this case, if nothing is returned, we return the 
$ifnull var. 
 
2) In many pages, there is something like that: 
$sql="select count(*) from people where 
lastlog>$prevlog and id!=$CRM_user 
 
the probleme is that the getvalue function can return 
"n/a", in this case, it's mandatory to single quote 
the "$prevlog" var (and by the way, the $CRM_user 
too)! 
$sql="select count(*) from people where 
lastlog>'$prevlog' and id!='$CRM_user' 
 
HTH 
 
Yann Sagon 
y dot sagon at hasa dot ch 
 

----------------------------------------------------------------------

>Comment By: Guy Davis (guy_davis)
Date: 2003-08-26 16:57

Message:
Logged In: YES 
user_id=22084

Please provide the following details regarding this bug report:



Description of the problem:





Steps to reproduce the problem:

1.

2.

3.



Actual Results:





Expected Results:





How often does this happen?





Software Version:

Additional Information:





Thanks.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=410239&aid=795344&group_id=34206