OpenSAF / Tickets / #2726 smf: Smfnd does not protect global variables used in more than one thread

smf: Smfnd does not protect global variables used in more than one thread

#2726 smf: Smfnd does not protect global variables used in more than one thread

Milestone: 5.21.06

Status: fixed

Owner: Thanh Nguyen

Labels: None

Type: defect

Component: smf

Part: nd

Version:

Priority: major

Blocker: False

Updated: 2021-06-01

Created: 2017-12-04

Creator: elunlen

Private: No

Several global variables (cb structure) are handled both in the main thread and in the mds thread but no mutex is used for protection. Make handling of global variables thread safe

elunlen - 2017-12-11

status: accepted --> assigned
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anders Widell - 2018-02-02

Milestone: 5.18.01 --> 5.18.04
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

elunlen - 2018-06-08

status: assigned --> unassigned
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Krishna Pawar - 2018-09-06

Part: - --> nd
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Krishna Pawar - 2018-09-06

Hi elunlen,
I have only seen cb->agent_cnt and cb->smfd_dest which are not protected. Do you see more variables in smfnd_mds.c which needs lock protection?
Thanks
Krishna

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Krishna Pawar - 2018-09-14

Any response?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Gary Lee - 2018-09-29

Milestone: 5.18.04 --> 5.18.12
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Gary Lee - 2019-01-09

Milestone: 5.19.01 --> future
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thanh Nguyen - 2021-03-28

status: unassigned --> assigned
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thanh Nguyen - 2021-04-07

status: assigned --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thanh Nguyen - 2021-04-07

assigned_to: elunlen --> Thanh Nguyen
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thanh Nguyen - 2021-04-26

status: review --> fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thanh Nguyen - 2021-04-26

Fixed with
5eb4b76fbaa13b2773f9a8e0a059a1e4d61febc2

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Gary Lee - 2021-06-01

Milestone: future --> 5.21.06
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

smf: Smfnd does not protect global variables used in more than one thread

Milestone

Searches

Help

#2726 smf: Smfnd does not protect global variables used in more than one thread

Related

Discussion