#2188 amfd: avd_imm_impl_set fails causing node reboot

[Gary Lee]

avd_imm_impl_set fails causing node reboot

It seems there may have been simultaneous IMM reinit threads running.

Nov 14 02:24:26 SC-2-2 osafamfd[4174]: NO Re-initializing with IMM
Nov 14 02:24:26 SC-2-2 osafamfd[4174]: NO Re-initializing with IMM
Nov 14 02:24:26 SC-2-2 osafimmnd[16412]: NO Implementer connected: 44 (safAmfService) <526, 2020f>
Nov 14 02:24:26 SC-2-2 osafamfd[4174]: NO Finished re-initializing with IMM
Nov 14 02:24:26 SC-2-2 osafamfd[4174]: ER saImmOiImplementerSet failed 14
Nov 14 02:24:26 SC-2-2 osafamfd[4174]: ER exiting since avd_imm_impl_set failed
Nov 14 02:24:26 SC-2-2 osafimmnd[16412]: NO Implementer locally disconnected. Marking it as doomed 44 <526, 2020f> (safAmfService)
Nov 14 02:24:26 SC-2-2 osafamfnd[4192]: WA AMF director unexpectedly crashed
Nov 14 02:24:26 SC-2-2 osafamfnd[4192]: Rebooting OpenSAF NodeId = 131599 EE Name = , Reason: local AVD down(Adest) or both AVD down(Vdest) received, OwnNodeId = 131599, SupervisionTime = 60
Nov 14 02:24:26 SC-2-2 osafimmnd[16412]: NO Implementer disconnected 44 <526, 2020f> (safAmfService)

[Gary Lee]

Hi

imm_sel_obj is unsigned. So perhaps this is an alternative:

diff --git a/osaf/services/saf/amf/amfd/main.cc b/osaf/services/saf/amf/amfd/main.cc
--- a/osaf/services/saf/amf/amfd/main.cc
+++ b/osaf/services/saf/amf/amfd/main.cc
@@ -646,7 +646,7 @@ static void main_loop(void)
            fds[FD_CLM].events = POLLIN;
        }

-       if (cb->immOiHandle != 0) {
+       if (cb->immOiHandle != 0 && cb->avd_imm_status == AVD_IMM_INIT_DONE) {
            fds[FD_IMM].fd = cb->imm_sel_obj;
            fds[FD_IMM].events = POLLIN;
            nfds = FD_IMM + 1;

[Praveen]

Hi Minh,
I think check suggested by Gary can be included.
Please push the version that you have tested along with this minor correction.

Thanks,
Praveen

[Minh Hon Chau]

Hi Praveen,

I have only tried to reproduce the coredump based on latest changeset but have not seen it again with trace. And I don't have any new patch officially to be tested, please push the patch that you think it can fix the problem, then change status of this ticket as well.

Thanks,
Minh

[Gary Lee]

changeset: 8378:faa07232b270
branch: opensaf-5.0.x
tag: tip
parent: 8372:8fec915ef08d
user: Gary Lee gary.lee@dektech.com.au
date: Tue Nov 29 20:28:27 2016 +1100
summary: amfd: ensure we have fully initialized IMM before using selection object [#2188]

changeset: 8377:4f47d9d4f48d
branch: opensaf-5.1.x
parent: 8373:03fc556a1e6b
user: Gary Lee gary.lee@dektech.com.au
date: Tue Nov 29 20:26:21 2016 +1100
summary: amfd: ensure we have fully initialized IMM before using selection object [#2188]

changeset: 8376:c047cfa3b941
user: Gary Lee gary.lee@dektech.com.au
date: Tue Nov 29 20:25:04 2016 +1100
summary: amfd: ensure we have fully initialized IMM before using selection object [#2188]

[Minh Hon Chau]

Hi Praveen

The coredump has been resolved since part of this V3 had been pushed under below changesets.

changeset: 8378:faa07232b270
changeset: 8377:4f47d9d4f48d
changeset: 8376:c047cfa3b941

So I set the ticket to fixed

Thanks,
Minh