Menu

#1704 imm: Use nanosecond resolution for time measurements

5.1.FC
fixed
None
enhancement
imm
nd
minor
2016-08-30
2016-03-18
No

There are currently time measurements for timeout handling in ImmModel, and possibly other places in the IMM service, that use low resolution time measurements. This is caused by using the time_t type for time stamps, which only has a resolution of seconds. A consequence of this is that the actual timeout can vary up to one second, depending on when (how long after the last clock "tick") the timer is started.

Instead, nanosecond resolution should be used. The osaf_clock_gettime() utility function declared in osaftime.h can be used to read the system clock with nanosecond resolution. Another option in C++ is to use std::chrono::steady_clock.

This ticket can be seen as a continuation of ticket [#1617], where we started to use osaf_clock_gettime() but still didn't change the type of the variables containing time-stamps from time_t to struct timespec.

Related

Tickets: #1617
Tickets: #1704
Wiki: NEWS-5.1.0

Discussion

  • Hung Nguyen

    Hung Nguyen - 2016-07-26
    • status: unassigned --> accepted
    • assigned_to: Hung Nguyen
    • Part: - --> nd
    • Milestone: future --> 5.1.FC
     
  • Hung Nguyen

    Hung Nguyen - 2016-08-23
    • status: accepted --> review
     
  • Hung Nguyen

    Hung Nguyen - 2016-08-24
    • status: review --> fixed
     
  • Hung Nguyen

    Hung Nguyen - 2016-08-28
    • status: fixed --> review
     
  • Hung Nguyen

    Hung Nguyen - 2016-08-28

    Sent out a patch to fix the problem with IMMND resending intro messages constantly
    https://sourceforge.net/p/opensaf/mailman/message/35308571/

    Aug 28 09:36:38 SC-2 osafimmnd[439]: WA Resending introduce-me - problems with MDS ? 0.101825
    Aug 28 09:36:38 SC-2 osafimmnd[439]: WA Resending introduce-me - problems with MDS ? 0.202881
    Aug 28 09:36:39 SC-2 osafimmnd[439]: WA Resending introduce-me - problems with MDS ? 0.303848
    Aug 28 09:36:39 SC-2 osafimmnd[439]: WA Resending introduce-me - problems with MDS ? 0.405328
    Aug 28 09:36:39 SC-2 osafimmnd[439]: WA Resending introduce-me - problems with MDS ? 0.506821
    Aug 28 09:36:39 SC-2 osafimmnd[439]: WA Resending introduce-me - problems with MDS ? 0.608214
    Aug 28 09:36:39 SC-2 osafimmnd[439]: WA Resending introduce-me - problems with MDS ? 0.709692
    Aug 28 09:36:39 SC-2 osafimmnd[439]: WA Resending introduce-me - problems with MDS ? 0.811176
    Aug 28 09:36:39 SC-2 osafimmnd[439]: WA Resending introduce-me - problems with MDS ? 0.912262 
    
     
  • Hung Nguyen

    Hung Nguyen - 2016-08-30
    • status: review --> fixed
     
  • Hung Nguyen

    Hung Nguyen - 2016-08-30

    default (5.1) [staging:6b6806]

    changeset: 7986:6b6806ad5d27
    user: Hung Nguyen hung.d.nguyen@dektech.com.au
    date: Sun Aug 28 09:28:34 2016 +0700
    summary: imm: Avoid jobDurationSec of zero [#1704]

     

    Related

    Commit: [6b6806]
    Tickets: #1704


Log in to post a comment.

MongoDB Logo MongoDB