OpenSAF / Tickets / #1299 smf: redundant <swAdd> and <swRemove> entries in single step procedures are ignored

Robert Apanowicz - 2015-04-07

status: unassigned --> assigned

assigned_to: Robert Apanowicz
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anders Bjornerstedt - 2015-04-10

A defect can not have future as milestone.
Either change to enhancement or set the proper milestone, i.e. where
the problem is observed back to oldest supported branch (4.4 currently).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Apanowicz - 2015-04-15

status: assigned --> review

Version: 4.4 --> 4.5

Milestone: future --> 4.6.1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anders Bjornerstedt - 2015-04-15
  
  Hi Robert,
  
  (1)
  The reporter of the ticket sets the version to the version they where testing omn.
  The maintainer that analyzes the ticket may move the version backwards if analysis shows the
  Problem existed earlier. The developer should not move the version forward unless the reporter was wrong /confused
  About which version they where using.
  If you set Version to 4.5 on this defect it means that was the earliest version the problem existed in.
  Is that correct? I.e. the problem does NOT exist in 4.4
  
  (2) Milestone should be set to the earliest version where the problem will be (or is) fixed.
  This would be 4.5 since we still support 4.5.
  
  Even if you fix the problem only in 4.5, it is of information value to know (from the ticket) the earliest version the
  Problem exists in.
  Equally important is to know the earliest version the problem is actually fixed in.
  This means by implication that the problem is fixed in later versions.
  
  I have seen an increasing confusion about version and milestone recently.
  I am not aware of any policy change in how we should handle this.
  
  /AndersBj
  
  From: Robert Apanowicz [mailto:eaparob@users.sf.net]
  Sent: den 15 april 2015 08:42
  To: [opensaf:tickets]
  Subject: [opensaf:tickets] #1299 smf: redundant <swAdd> and <swRemove> entries in single step procedures are ignored
  
  status: assigned --> review
  
  Version: 4.4 --> 4.5
  
  Milestone: future --> 4.6.1
  
  [tickets:#1299]http://sourceforge.net/p/opensaf/tickets/1299 smf: redundant <swAdd> and <swRemove> entries in single step procedures are ignored
  
  Status: review
  Milestone: 4.6.1
  Created: Thu Apr 02, 2015 11:46 AM UTC by Robert Apanowicz
  Last Updated: Fri Apr 10, 2015 08:11 AM UTC
  Owner: Robert Apanowicz
  
  In SmfCampaignXmlParser::parseCampaignXml() the checking is only implemented for the rolling procedure case where:
  the redundant <swAdd> and <swRemove> entries are removed.
  
  Single step procedures shall be treated the same way as rolling procedures.
  
  Comments from the source code:
  
  //For the procedure, check if the same SwBudle DN exist in both swAdd and swRemove lists
  //In that case the SwBundle shall not be touched, remove the SwBundle DN from the lists.
  
  Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/opensaf/tickets/1299/https://sourceforge.net/p/opensaf/tickets/1299
  
  To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/https://sourceforge.net/auth/subscriptions
  
  Related
  
  Tickets: ~~#1299~~
  
  alternate
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Robert Apanowicz - 2015-04-15
    
    Hi Anders,
    
    Thanks for the clarification. The ticket will be changed according to that.
    
    Is there a document or some kind of description on how to use those fields ("Milestone", "Version" etc.) ?
    
    Br,
    
    Robert
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    - Anders Bjornerstedt - 2015-04-15
      
      Good question.
      
      https://sourceforge.net/p/opensaf/wiki/Development%20Process/
      
      https://sourceforge.net/p/opensaf/wiki/write%20a%20ticket/
      
      /AndersBj
      
      From: Robert Apanowicz [mailto:eaparob@users.sf.net]
      Sent: den 15 april 2015 09:49
      To: [opensaf:tickets]
      Subject: [opensaf:tickets] Re: #1299 smf: redundant <swAdd> and <swRemove> entries in single step procedures are ignored
      
      Hi Anders,
      
      Thanks for the clarification. The ticket will be changed according to that.
      
      Is there a document or some kind of description on how to use those fields ("Milestone", "Version" etc.) ?
      
      Br,
      
      Robert
      
      [tickets:#1299]http://sourceforge.net/p/opensaf/tickets/1299 smf: redundant <swAdd> and <swRemove> entries in single step procedures are ignored
      
      Status: review
      Milestone: 4.6.1
      Created: Thu Apr 02, 2015 11:46 AM UTC by Robert Apanowicz
      Last Updated: Wed Apr 15, 2015 07:06 AM UTC
      Owner: Robert Apanowicz
      
      In SmfCampaignXmlParser::parseCampaignXml() the checking is only implemented for the rolling procedure case where:
      the redundant <swAdd> and <swRemove> entries are removed.
      
      Single step procedures shall be treated the same way as rolling procedures.
      
      Comments from the source code:
      
      //For the procedure, check if the same SwBudle DN exist in both swAdd and swRemove lists
      //In that case the SwBundle shall not be touched, remove the SwBundle DN from the lists.
      
      Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/opensaf/tickets/1299/https://sourceforge.net/p/opensaf/tickets/1299
      
      To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/https://sourceforge.net/auth/subscriptions
      
      Related
      
      Tickets: ~~#1299~~
      
      alternate
      
      If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Apanowicz - 2015-04-15

For SingleStep upgrade scope the following 2 cases needed "removeSwAddRemoveDuplicates" implementation:
-forAddRemove
-forModify

The implementation of "removeSwAddRemoveDuplicates" in Rolling upgrade is not possible to use for SingleStep as it is right now.
In Rolling case the lists (add/remove, which need to be filtered) store different types then the lists in the SingleStep case.

The new implementation of forAddRemove and forModify uses a common method ("removeSwAddRemoveDuplicates") for filtering.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Apanowicz - 2015-04-15

The implementation of "removeSwAddRemoveDuplicates" in Rolling upgrade could cause a problem, since it only filters out the first duplicate pair of a specific add/remove duplicate from the lists.
A campaign example where the duplicates not filtered out correctly (this case most likely won't happen in reality):

under targetNodeTemplate within Rolling upgrade scope:
...
<swRemove bundleDN="safSmfBundle=A" pathnamePrefix="/opt/a"/>
<swRemove bundleDN="safSmfBundle=A" pathnamePrefix="/opt/a"/>
<swAdd bundleDN="safSmfBundle=A" pathnamePrefix="/opt/a"/>
...

In this case the add/remove pair will be filtered out, and the remaining "remove" won't be deleted from the list.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ingvar Bergström - 2015-04-16

status: review --> fixed

Version: 4.5 --> 4.4

Milestone: 4.6.1 --> 4.5.1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ingvar Bergström - 2015-04-16

changeset: 6480:6fa5ee0bc4d4
tag: tip
parent: 6477:29cbb9e3c859
user: Robert Apanowicz robert.apanowicz@ericsson.com
date: Tue Apr 14 10:49:07 2015 +0200
summary: smf: redundant <swAdd> and <swRemove> entries in single step procedures are removed [#1299]

changeset: 6479:43dcc23b0336
branch: opensaf-4.6.x
parent: 6476:712340762044
user: Robert Apanowicz robert.apanowicz@ericsson.com
date: Tue Apr 14 10:49:07 2015 +0200
summary: smf: redundant <swAdd> and <swRemove> entries in single step procedures are removed [#1299]

changeset: 6478:431248e42a9e
branch: opensaf-4.5.x
parent: 6475:9efc31715bdf
user: Robert Apanowicz robert.apanowicz@ericsson.com
date: Tue Apr 14 10:49:07 2015 +0200
summary: smf: redundant <swAdd> and <swRemove> entries in single step procedures are removed [#1299]

Related

Tickets: ~~#1299~~

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

smf: redundant <swAdd> and <swRemove> entries in single step procedures are ignored

Milestone

Searches

Help

#1299 smf: redundant <swAdd> and <swRemove> entries in single step procedures are ignored

Related

Discussion

Related

Related

Related