[devel] [PATCH 0/2] Review Request for imm: fix realloc failure handling in XML import [#3398]

[Thien H. <thi...@en...>]

Summary: amfd: add continue after avd_si_delete on standby node [#3398]
Review request for Ticket(s): 3398
Peer Reviewer(s): Thang, Dat
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3398
Base revision: ea0c7cce3fa4593f556016fa3506126c6d3f5c21
Personal repository: git://git.code.sf.net/u/thienhuynh/review

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   y

NOTE: Patch(es) contain lines longer than 80 characers

Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***

revision 62eb2d53ac34fa9f73c810ac80dcabe3944eb44e
Author: Thien Minh Huynh <thi...@en...>
Date:   Tue, 12 May 2026 04:25:22 +0200

imm: fix realloc failure handling in XML import [#3398]

Fix potential memory leaks in imm_loader.cc, imm_cfg.c, and
imm_import.cc where the result of realloc() was assigned directly
to the original pointer. If realloc() fails and returns NULL, the
original memory is leaked.

Use a temporary variable to hold the realloc() result, check for
NULL, and only then assign back to the original pointer. Also add
missing NULL checks and proper cleanup on failure paths.



revision b484b6237e7efe68d29c056adfa56bafa9d9ee39
Author: Thien Minh Huynh <thi...@en...>
Date:   Tue, 12 May 2026 04:24:01 +0200

amfd: add continue after avd_si_delete on standby node [#3398]

When avd_csi_config_get returns SA_AIS_ERR_NOT_EXIST on a standby
node, the SI is deleted but execution falls through to the else
branch causing an unnecessary goto done2. Add continue to skip
to the next iteration after deleting the SI.



Complete diffstat:
------------------
 src/amf/amfd/si.cc             |  1 +
 src/imm/immloadd/imm_loader.cc | 23 ++++++++++++++++-----
 src/imm/tools/imm_cfg.c        | 47 ++++++++++++++++++++++++++++++++++--------
 src/imm/tools/imm_import.cc    | 19 ++++++++++++-----
 4 files changed, 71 insertions(+), 19 deletions(-)


Testing Commands:
-----------------
N/A

Testing, Expected Results:
--------------------------
N/A

Conditions of Submission:
-------------------------
ACK from reviewers

Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


The information in this email is confidential and may be legally privileged. It is intended solely for the addressee. Any opinions expressed are mine and do not necessarily represent the opinions of the Company. Emails are susceptible to interference. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is strictly prohibited and may be unlawful. If you have received this message in error, do not open any attachments but please notify the Endava Service Desk on (+44 (0)870 423 0187), and delete this message from your system. The sender accepts no responsibility for information, errors or omissions in this email, or for its use or misuse, or for any act committed or omitted in connection with this communication. If in doubt, please verify the authenticity of the contents with the sender. Please rely on your own virus checkers as no responsibility is taken by the sender for any damage rising out of any bug or virus infection.

Endava plc is a company registered in England under company number 5722669 whose registered office is at 125 Old Broad Street, London, EC2N 1AR, United Kingdom. Endava plc is the Endava group holding company and does not provide any services to clients. Each of Endava plc and its subsidiaries is a separate legal entity and has no liability for another such entity's acts or omissions.