[tickets] [opensaf:tickets] #2419 smf: when fixing ticket #2145 a NBC problem was introduced

[Alex J. <trg...@us...>]

I'm not sure this is the right thing to do.

If this problem is handled in AMF, now someone can turn off the behavior in the middle of a campaign. AMF doesn't know if a campaign is executing, and would just blindly enable/disable the auto repair which could be dangerous.

I think Rafael's suggestion from 4/13 is the right thing to do. Then if someone wants to turn the behavior on or off, SMF can reject it in the middle of a campaign.


---

** [tickets:#2419] smf: when fixing ticket #2145 a NBC problem was introduced**

**Status:** wontfix
**Milestone:** 5.2.0
**Created:** Mon Apr 10, 2017 11:11 AM UTC by elunlen
**Last Updated:** Fri Apr 21, 2017 08:40 AM UTC
**Owner:** nobody


Previous behavior:
The behavior was to ignore a fail to activate a component unless any secondary fault happened. This means that it was for example possible to complete a campaign even if a component failed to start and fix this problem after committing. No action to resume the campaign was needed.

After [#2145]:
The campaign will always suspend in case of component fail and a resume must be requested for the campaign to continue.

NBC:
The behavior has changed in such a way that it must be seen as a NBC. The #2145 ticket corrects SMF behavior regarding AIS but is still NBC since the previous behavior is the legacy behavior in previous releases.

Proposal 1; Fix if not needed to change setting in runtime e.g. during an upgrade
Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior.
The setting must have the following properties:
- If the attribute does not exist (old model)		legacy behavior
- If the attribute value is not changed from default	legacy behavior
- If the attribute value is <empty> or invalid		legacy behavior
- If the attribute value is a valid “ON” setting		new behavior
- A request to change the attribute in runtime shall always be rejected

Proposal 2; Fix if change has to be made during upgrade:
Add a new configuration attribute to the SMF configuration class that makes it possible to select whether the behavior after #2145 shall be used or not. The default setting must be the previous behavior.
The setting must have the following properties:
- If the attribute does not exist (old model)		legacy behavior
- If the attribute value is not changed from default	legacy behavior
- If the attribute value is <empty> or invalid		legacy behavior
- If the attribute value is a valid “ON” setting		new behavior
- Attribute value must be possible to change in runtime in “idle” state (no campaign is executing)
- Attribute value must be possible to change in runtime in campaign init state. Note that if changed here
  the new setting must be used in the rest of the campaign



---

Sent from sourceforge.net because ope...@li... is subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.