[devel] [PATCH 0 of 1] Review Request for immtools: audit no dangling references in PBE file [#19]

[Zoran M. <zor...@er...>]

Summary: immtools: audit no dangling references in PBE file [#19]
Review request for Trac Ticket(s): 19
Peer Reviewer(s): Neelakanta, Anders, Hung
Pull request to: Zoran
Affected branch(es): default(4.7)
Development branch: default(4.7)

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 74a32d094b21762d5cd226a0f543134ad3d8b654
Author:	Zoran Milinkovic <zor...@er...>
Date:	Thu, 04 Jun 2015 14:09:20 +0200

	immtools: audit no dangling references in PBE file [#19]

	The patch covers only aditing no dangling references. It's required by
	critical ticket #1377. The patch first check no dangling references for
	multi-value attributes, then it checks no dangling references for non multi
	value attributes. This is done in two steps because values for multi value
	attributes are stored in another table.

	The patch is done in libs/common/immsv, so that it can be used by IMM PBE in
	later implementation. If the audit fails, one line is written in the
	console. Other auditing details are logged in syslog.


Complete diffstat:
------------------
 osaf/libs/common/immsv/immpbe_dump.cc         |  125 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 osaf/libs/common/immsv/include/immpbe_dump.hh |    3 +++
 osaf/tools/safimm/immdump/imm_dumper.cc       |   35 +++++++++++++++++++++++++++++------
 3 files changed, 156 insertions(+), 7 deletions(-)


Testing Commands:
-----------------
immdump -a pbe_file.db
immdump --audit pbe_file.db


Testing, Expected Results:
--------------------------
Test immdump with correct pbe file, and with corrupted NO_DANGLING references.


Conditions of Submission:
-------------------------
Ack from Neelakanta, Anders, Hung


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      n          n
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.