|
From: openocd-gerrit <ope...@us...> - 2026-10-11 09:59:29
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via b20f0fb10b4352618c7de707390a3346d93aad2e (commit)
from 0e6ae2525d64a4b39d65f21a4ad6069daa8af3f1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b20f0fb10b4352618c7de707390a3346d93aad2e
Author: Nguyen Minh Tien <tie...@em...>
Date: Wed Sep 30 19:10:42 2026 +0700
tcl/target/allwinner_v3s: create the DAP with 'dap create'
The config does not load:
Error: target requires -dap parameter instead of -tap
A cortex_a target takes its DAP from '-dap' and refuses '-tap' (before
that '-chain-position'). That was already the case when the file was
added: 0.12.0 fails the same way, naming '-chain-position'.
Create the DAP on the existing TAP and pass it with '-dap', as
ls1046a.cfg does. The TAP, the DAP and the target keep their names
(v3s.dap, v3s.cpu).
Checked with the dummy adapter only: the config loads and creates the
cortex_a target v3s.cpu on the DAP v3s.dap.
Fixes: f8367dbb4976 ("tcl/target: add Allwinner V3s SoC support")
Change-Id: Ie8396b7ffbb2b494a74bcfe7fe0f4241cbcf1f7b
Signed-off-by: Nguyen Minh Tien <tie...@em...>
Reviewed-on: https://review.openocd.org/c/openocd/+/10080
Tested-by: jenkins
Reviewed-by: Antonio Borneo <bor...@gm...>
diff --git a/tcl/target/allwinner_v3s.cfg b/tcl/target/allwinner_v3s.cfg
index dd0ce476f..8b22d8a1c 100644
--- a/tcl/target/allwinner_v3s.cfg
+++ b/tcl/target/allwinner_v3s.cfg
@@ -68,6 +68,8 @@ reset_config none srst_pulls_trst
jtag newtap $_CHIPNAME dap -irlen 4 -ircapture 0x01 -irmask 0x0f \
-expected-id $_DAP_TAPID
+dap create $_CHIPNAME.dap -tap $_CHIPNAME.dap
+
# Add Cortex A7 core
set _TARGETNAME $_CHIPNAME.cpu
-target create $_TARGETNAME cortex_a -tap $_CHIPNAME.dap
+target create $_TARGETNAME cortex_a -dap $_CHIPNAME.dap
-----------------------------------------------------------------------
Summary of changes:
tcl/target/allwinner_v3s.cfg | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
hooks/post-receive
--
Main OpenOCD repository
|