|
From: openocd-gerrit <ope...@us...> - 2026-05-27 18:07:11
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via f92f577cc0dcc14c63ff31fd7bd5144b3120443b (commit)
from dc803e74be21678b8e867cb01609ed59a446ec09 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit f92f577cc0dcc14c63ff31fd7bd5144b3120443b
Author: Tomas Vanek <va...@fb...>
Date: Thu May 21 07:32:48 2026 +0200
jtag/core: fix blocked polling in unknown state of jtag_xrst
Patch [1] neglected three state character of jtag_trst variable,
similarly the original code did for jtag_srst.
Block polling only if SRST / TRST state is known and set.
Fixes: [1] commit eeacc589af60 ("jtag/core: fix is_jtag_poll_safe() logic")
Change-Id: I058491d5f0523af1690141787ec74bd21ad0832e
Signed-off-by: Tomas Vanek <va...@fb...>
Reported-by: Marc Schink <de...@za...>
Reviewed-on: https://review.openocd.org/c/openocd/+/9669
Tested-by: jenkins
Reviewed-by: zapb <de...@za...>
diff --git a/src/jtag/core.c b/src/jtag/core.c
index 9c438a01b..08228c024 100644
--- a/src/jtag/core.c
+++ b/src/jtag/core.c
@@ -151,11 +151,11 @@ bool is_jtag_poll_safe(void)
return false;
/* On JTAG transport it is also implicitly disabled while TRST is active */
- if (transport_is_jtag() && jtag_trst)
+ if (transport_is_jtag() && jtag_trst == 1)
return false;
/* On any transport while SRST is gating the JTAG clock or other debug HW */
- return jtag_srst == 0 || (jtag_reset_config & RESET_SRST_NO_GATING);
+ return jtag_srst != 1 || (jtag_reset_config & RESET_SRST_NO_GATING);
}
bool jtag_poll_get_enabled(void)
-----------------------------------------------------------------------
Summary of changes:
src/jtag/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|