[OpenOCD-devel] [PATCH]: 85053d3 armv8: log the register name which we failed to read or write

[<ge...@op...>]

This is an automated email from Gerrit.

Tarek BOCHKATI (tar...@gm...) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/5516

-- gerrit

commit 85053d3d2b6ede9442cf0e4d9a20052d01a68211
Author: Tarek BOCHKATI <tar...@gm...>
Date:   Fri Mar 13 11:49:25 2020 +0100

    armv8: log the register name which we failed to read or write
    
    when openocd fails to read armv8 register, the user is not informed
    which register has caused the error.
    
    for example, in AArch32 state ESR_EL3 read/write is not supported,
    thus armv8_dpm_read_current_registers is always failing without mentioning
    which register has caused the error.
    
    Change-Id: I24c5abbda9fac24fb77a01777ed15261aeaaf800
    Signed-off-by: Tarek BOCHKATI <tar...@gm...>

diff --git a/src/target/armv8_dpm.c b/src/target/armv8_dpm.c
index 081eed2..5be5272 100644
--- a/src/target/armv8_dpm.c
+++ b/src/target/armv8_dpm.c
@@ -681,6 +681,10 @@ static int dpmv8_read_reg(struct arm_dpm *dpm, struct reg *r, unsigned regnum)
 			LOG_DEBUG("READ: %s, hvalue=%16.8llx", r->name, (unsigned long long) hvalue);
 		}
 	}
+
+	if (retval != ERROR_OK)
+		LOG_ERROR("Failed to read %s register", r->name);
+
 	return retval;
 }
 
@@ -720,6 +724,9 @@ static int dpmv8_write_reg(struct arm_dpm *dpm, struct reg *r, unsigned regnum)
 		}
 	}
 
+	if (retval != ERROR_OK)
+		LOG_ERROR("Failed to write %s register", r->name);
+
 	return retval;
 }
 

--