[OpenOCD-devel] [openocd:tickets] #232 semihosting_fileio read return wrong number of read bytes

[Liviu I. (ilg) <il...@us...>]

If you mean the comments in semihosting_common.c, the SEMIHOSTING_SYS_READ case, they do not refer to the gdb client protocol, but to the arm semihosting protol (I contributed that file, and the large comment blocks were copied from the arm semihosting pdf file).

As for the SF behaviour, no comments, I moved everything to GitHub several years ago.

As for using Gerrit to contribute patches to OpenOCD,, there are some explanations somewhere on the OpenOCD site, it is basically a git thing, you push commits to some custom branches and they are validated and later merged into the master branch. If you never did Gerrit before, it might be an useful experience, possibly frustrating initially, but generally ok.


---

** [tickets:#232] semihosting_fileio read return wrong number of read bytes**

**Status:** new
**Milestone:** 0.9.0
**Created:** Sun Apr 21, 2019 04:18 PM UTC by hogthrob
**Last Updated:** Sun Apr 21, 2019 08:31 PM UTC
**Owner:** nobody


The current implementation of read for semihosting_fileio read  works only for reads returning exactly the requested amount OR in case of EOF/ERROR.

In the case of "not full" read with respect to requested bytes, the number of requested bytes - returned bytes was returned (i.e. how many bytes have not been read), which should have been the number of read bytes.

Please integrate the following fix:

https://github.com/db4ple/openocd/commit/0a87bac689a271c8e6fb97a48ee23e4d019a4438



---

Sent from sourceforge.net because ope...@li... is subscribed to https://sourceforge.net/p/openocd/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/openocd/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.