[OpenOCD-devel] [openocd:tickets] #232 semihosting_fileio read return wrong number of read bytes

[hogthrob <hog...@us...>]

Sure. In order to understand this patch, you have to read the comments given on first half of the SYS_READ in the same file somewhere above explaining the GDB protocol return value for SYS_READ

The GDB remote semihosting protocol implements SYS_READ but  returns the (requested bytes - actually read bytes) in its result value. The patched function translates this return value into values which would be returned from the "normal" read call (the number of bytes actually read).

I have no idea how to use Gerrit, is there some kind of instructions available. BTW, I tried to fork the OpenOCD repository on SF and many hours later I got an email from SF telling me that this operation failed. If a fork is necessary to submit something to Gerrit, I am out of business...




---

** [tickets:#232] semihosting_fileio read return wrong number of read bytes**

**Status:** new
**Milestone:** 0.9.0
**Created:** Sun Apr 21, 2019 04:18 PM UTC by hogthrob
**Last Updated:** Sun Apr 21, 2019 07:07 PM UTC
**Owner:** nobody


The current implementation of read for semihosting_fileio read  works only for reads returning exactly the requested amount OR in case of EOF/ERROR.

In the case of "not full" read with respect to requested bytes, the number of requested bytes - returned bytes was returned (i.e. how many bytes have not been read), which should have been the number of read bytes.

Please integrate the following fix:

https://github.com/db4ple/openocd/commit/0a87bac689a271c8e6fb97a48ee23e4d019a4438



---

Sent from sourceforge.net because ope...@li... is subscribed to https://sourceforge.net/p/openocd/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/openocd/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.