[OpenOCD-devel] [openocd:tickets] #232 semihosting_fileio read return wrong number of read bytes

[Liviu I. (ilg) <il...@us...>]

I confirm that for partial reads the SEMIHOSTING_SYS_READ call should return the number of remaining bytes, and the regular (not the fileio) case does this.

However I do not have experience with the fileio use case. Your patch seems ok, but I'd like someone more experienced to confirm this. 

Perhaps you can also explain in a few words how this works. Is the call forwarded to the gdb client? What is this call returning for partial reads?

Anyway, if the maintainers aggree on this patch, I suggest you submmit it via Gerrit.


---

** [tickets:#232] semihosting_fileio read return wrong number of read bytes**

**Status:** new
**Milestone:** 0.9.0
**Created:** Sun Apr 21, 2019 04:18 PM UTC by hogthrob
**Last Updated:** Sun Apr 21, 2019 04:18 PM UTC
**Owner:** nobody


The current implementation of read for semihosting_fileio read  works only for reads returning exactly the requested amount OR in case of EOF/ERROR.

In the case of "not full" read with respect to requested bytes, the number of requested bytes - returned bytes was returned (i.e. how many bytes have not been read), which should have been the number of read bytes.

Please integrate the following fix:

https://github.com/db4ple/openocd/commit/0a87bac689a271c8e6fb97a48ee23e4d019a4438



---

Sent from sourceforge.net because ope...@li... is subscribed to https://sourceforge.net/p/openocd/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/openocd/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.