[OpenOCD-devel] [PATCH]: ed2a7fe COVER LETTER: Handle Tcl return values consistently

[<ge...@op...>]

This is an automated email from Gerrit.

Antonio Borneo (bor...@gm...) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/5046

-- gerrit

commit ed2a7fef1e5fdc64c776a1245a5736259d0031d2
Author: Antonio Borneo <bor...@gm...>
Date:   Sun Apr 7 06:09:09 2019 +0200

    COVER LETTER: Handle Tcl return values consistently
    
    This (very) long series is the result of splitting commit 1815 in
    patches simpler and easier to review.
    In the same series there is some additional preparation patch, and
    some further fix after.
    The job is not complete; additional fixes could either be added at
    this series or proposed later.
    
    These initial patches are proposed to fix what was not completed
    in 1815, and are now part of the preparation steps:
    
    1) target: rewrite jim_target_event_list to handle_target_event_list
    2) target/arm946e: rewrite jim_arm946e_cp15 to arm945e_handle_cp15
    3) helper/command: add macro CMD
    4) target: change prototype of target_process_reset()
    5) target: use LOG_USER to print errors in events
    6) target: unify memory read/write commands
    7) target_request: replace command_print() with command_output_text()
    
    Then there is the series of small changes taken from 1815, also
    used as preparation stage:
    
    8) nand/fileio: change prototype of nand_fileio_start()
    9) nand/tcl: pass CMD to nand_list_walker()
    10) nor/at91sam3: change prototype of get_current_sam3()
    11) nor/at91sam4: change prototype of get_current_sam4()
    12) target/arm920t: change prototype of arm920t_verify_pointer()
    13) target/arm926ejs: change prototype of arm926ejs_verify_pointer()
    14) target/arm966e: change prototype of arm966e_verify_pointer()
    15) target/arm720t: change prototype of arm720t_verify_pointer()
    16) target/arm946e: change prototype of arm946e_verify_pointer()
    17) target/cortex_m: change prototype of cortex_m_verify_pointer()
    18) target/mips32: change prototype of mips32_verify_pointer()
    19) target/mips_m4k: change prototype of mips_m4k_verify_pointer()
    20) target/xscale: change prototype of xscale_verify_pointer()
    21) target/xscale: change prototype of xscale_display_instruction()
    22) target/armv8: change prototype of display_cache_info()
    23) target/dsp563xx: change prototype of handle_md_output()
    24) target/armv4_5_cache: change prototype of armv4_5_handle_cache_info_command()
    25) target/armv7a: change prototype of armv7a_handle_cache_info_command()
    26) target/armv7a_cache_l2x: change prototype of arm7a_handle_l2x_cache_info_command()
    27) target/x86_32_common: change prototype of handle_iod_output()
    28) target/etm: change prototype of etmv1_analyze_trace()
    29) target/arm_adi_v5: change prototype of dap_rom_display()
    30) target: change prototype of handle_md_output()
    31) target: change prototype of handle_bp_command_list()
    32) target: change prototype of handle_bp_command_set()
    33) target: change prototype of binprint()
    34) target/esirisc_trace: change prototype of trace analyse functions
    35) target/esirisc_trace: change prototype of trace dump functions
    36) jlink: change prototype of show_config*() functions
    
    This is the big ugly part. Now it is done through scripts, so
    trivial to review:
    
    37) helper/command: change prototype of command_print/command_print_sameline
    
    Completed the preparation, finally the core parts of 1815.
    
    38) nor/niietcm4: fix indentation
    39) flash/nor: use command_print() in command "flash banks"
    40) helper/command: remove command "command type"
    41) helper/command: Handle Tcl return values consistently
    42) helper/command: do not capture log in script_command_run()
    43) helper/command: do not replace new commands with ocd_ prefix
    
    And at last, some extra fix on my side:
    
    44) helper/command: remove search for "ocd_" prefix
    45) doc: remove references to "ocd_" prefixed commands
    46) TODO: remove references to "ocd_" prefix in documentation
    47) tcl/psoc4: remove "ocd_" prefixed commands
    48) helper/command: deprecate the old commands "ocd_%s"
    49) target: fix output of command "targets"
    50) helper/command: send command output only to the right server
                                                                                                                                                                  77,1          Bot
    Change-Id: I820d58bfd88aadf67249d0266dcb39f4b70a64d2
    Signed-off-by: Antonio Borneo <bor...@gm...>

--