Re: [OpenOCD-devel] Old -coreid setresult bug?

[Matthias W. <mat...@sy...>]

On Dienstag, 2. April 2019 22:40:14 CEST Tim Newsome wrote:
> A coworker noticed this snipped of code in target.c:
> case TCFG_COREID:
> if (goi->isconfigure) {
> e = Jim_GetOpt_Wide(goi, &w);
> if (e != JIM_OK)
> return e;
> target->coreid = (int32_t)w;
> } else {
> if (goi->argc != 0)
> goto no_params;
> }
> Jim_SetResult(goi->interp, Jim_NewIntObj(goi->interp,
> target->working_area_size));
> /* loop for more */
> break;
> 
> He remarked that the result should probably be target->coreid instead of
> target->working_area_size, and I'm inclined to agree. But since I don't
> really understand this code, nor know how to really test it, I'm not
> comfortable making the change or even declaring it a real bug. But now at
> least it's been passed up the chain. If this means something to somebody,
> it can be fixed. :-)

Yes, even if it's there since the original commit (which means it got past the review like 
that!) that introduced coreid, it's a bug and I'd appreciate a fix.

Thanks for spotting this!

BR,
Matthias

> 
> Tim


-- 
Mit freundlichen Grüßen/Best regards,

Matthias Welwarsky
Project Engineer

SYSGO AG
Office Mainz
Am Pfaffenstein 14 / D-55270 Klein-Winternheim / Germany
Phone: +49-6136-9948-0 / Fax: +49-6136-9948-10
VoIP: SIP:ma...@sy...
E-mail: mat...@sy... / Web: http://www.sysgo.com
_________________________________________________________________________________ Web: 
https://www.sysgo.com
Blog: https://www.sysgo.com/blog
Events: https://www.sysgo.com/events
Newsletter: https://www.sysgo.com/newsletter 
_________________________________________________________________________________ 
Handelsregister/Commercial Registry: HRB Mainz 90 HRB 8066
Vorstand/Executive Board: Etienne Butery (CEO), Kai Sablotny (COO)
Aufsichtsratsvorsitzender/Supervisory Board Chairman: Marc Darmon
USt-Id-Nr./VAT-Id-No.: DE 149062328