[OpenOCD-devel] [PATCH]: bd787ad target/cortex_m: return error if breakpoint address is out of range

[<ge...@op...>]

This is an automated email from Gerrit.

Antonio Borneo (bor...@gm...) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/4535

-- gerrit

commit bd787ad9cdf57e67f466fc867ec89ebf507c6c8e
Author: Antonio Borneo <bor...@gm...>
Date:   Tue May 29 23:40:36 2018 +0200

    target/cortex_m: return error if breakpoint address is out of range
    
    If the "Flash Patch and Breakpoint" unit is rev.1 then it can only
    accept breakpoint addresses below 0x1FFFFFFF.
    Detailed info in "ARM v7-M Architecture Reference Manual", DDI0403E
    at chapter "C1.11 Flash Patch and Breakpoint unit".
    
    Print a message and return error if the address of hardware
    breakpoint cannot be handled by the breakpoint unit.
    
    Change-Id: I95c92b1f058f0dfc568bf03015f99e439b27c59b
    Signed-off-by: Antonio Borneo <bor...@gm...>

diff --git a/src/target/cortex_m.c b/src/target/cortex_m.c
index 30439f4..7c667f0 100644
--- a/src/target/cortex_m.c
+++ b/src/target/cortex_m.c
@@ -1137,6 +1137,10 @@ int cortex_m_set_breakpoint(struct target *target, struct breakpoint *breakpoint
 		breakpoint->set = fp_num + 1;
 		fpcr_value = breakpoint->address | 1;
 		if (cortex_m->fp_rev == 0) {
+			if (breakpoint->address > 0x1FFFFFFF) {
+				LOG_ERROR("Cortex-M Flash Patch Breakpoint rev.0 cannot handle HW breakpoint above address 0x1FFFFFFE");
+				return ERROR_FAIL;
+			}
 			uint32_t hilo;
 			hilo = (breakpoint->address & 0x2) ? FPCR_REPLACE_BKPT_HIGH : FPCR_REPLACE_BKPT_LOW;
 			fpcr_value = (fpcr_value & 0x1FFFFFFC) | hilo | 1;

--