|
From: <ge...@op...> - 2018-04-23 09:05:54
|
This is an automated email from Gerrit. Paul Fertser (fer...@gm...) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/4500 -- gerrit commit ec5f3e2c038319c91bf77757d2e4d5a14755c42d Author: Paul Fertser <fer...@gm...> Date: Mon Apr 23 12:03:53 2018 +0300 jtag: drivers: kitprog: fix strncpy warning GCC8 reports a new warning when strncpy bound depends on the length of the source argument (and not the destination). Fix this by using a more appropriate function instead. Change-Id: Ib221dcb0d0c7206aaca981183fbe737e8f7ab10f Signed-off-by: Paul Fertser <fer...@gm...> diff --git a/src/jtag/drivers/kitprog.c b/src/jtag/drivers/kitprog.c index 522eb17..e3ad84d 100644 --- a/src/jtag/drivers/kitprog.c +++ b/src/jtag/drivers/kitprog.c @@ -888,13 +888,11 @@ COMMAND_HANDLER(kitprog_handle_acquire_psoc_command) COMMAND_HANDLER(kitprog_handle_serial_command) { if (CMD_ARGC == 1) { - size_t len = strlen(CMD_ARGV[0]); - kitprog_serial = calloc(len + 1, sizeof(char)); + kitprog_serial = strdup(CMD_ARGV[0]); if (kitprog_serial == NULL) { LOG_ERROR("Failed to allocate memory for the serial number"); return ERROR_FAIL; } - strncpy(kitprog_serial, CMD_ARGV[0], len + 1); } else { LOG_ERROR("expected exactly one argument to kitprog_serial <serial-number>"); return ERROR_FAIL; -- |