Re: [OpenOCD-devel] [PATCH] imx8m: add an m4 target to the imx8m

[Angus A. <an...@ak...>]

On 2018-04-19 15:16, Angus Ainslie wrote:
> On 2018-04-19 14:37, Paul Fertser wrote:
>> Hello Angus,
>> 
>> Thank you for the patch.
>> 
>> Can you please consider sending this to Gerrit as per HACKING
>> instructions?
>> 
> 
> Ok I'll re-submit based on those instructions.
> 
>> Quick review inline.
>> 
>> On Thu, Apr 19, 2018 at 02:05:47PM -0600, Angus Ainslie wrote:
>>> +${_CHIPNAME}.m4 configure -event reset-init { m4_init }
>>> +
>>> +proc m4_init { } {
>>> +  echo "m4 reset-init..."
>>> +  cortex_m dbginit
>> 
>> I do not see dbginit command in cortex_m group, have you actually
>> runtime-tested this?
>> 
> 
> I had tested with an earlier version but I see that there isn't that
> command int the cortex_m group.
> 
>>> +  # halt the CPU
>>> +  halt
>> 
>> I expected "reset init" to halt all the enabled targets. Are you sure
>> that's not happening?
> 
> Right now none of the targets are halting. There seems to be a
> disconnect between what openocd thinks is happening and what is going
> on in the HW. This shows that openocd thinks the A53 core is running
> but it is not.
> 

Trashed the serial port so it was actually running and I'll send up a 
new (working) patch .