Re: [OpenOCD-devel] [PATCH] imx8m: add an m4 target to the imx8m

[Paul F. <fer...@gm...>]

Hello Angus,

Thank you for the patch.

Can you please consider sending this to Gerrit as per HACKING
instructions?

Quick review inline.

On Thu, Apr 19, 2018 at 02:05:47PM -0600, Angus Ainslie wrote:
> +${_CHIPNAME}.m4 configure -event reset-init { m4_init }
> +
> +proc m4_init { } {
> +  echo "m4 reset-init..."
> +  cortex_m dbginit

I do not see dbginit command in cortex_m group, have you actually
runtime-tested this?

> +  # halt the CPU
> +  halt

I expected "reset init" to halt all the enabled targets. Are you sure
that's not happening?

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fer...@gm...