|
From: Andreas F. <afa...@su...> - 2017-03-23 17:53:02
|
Hi, Am 21.03.2017 um 14:07 schrieb Mykhaylo Lyubun: > 1) How long usually execute code review (this question from my manager)? There is no definite answer to this question. It can take two weeks or multiple months - having code and commit message in a well-structured, easy-to-review way helps, as does only pushing new patch versions when you believe they are ready to be reviewed. Adding Tcl configs in a separate patch, before adding flash drivers and then enhancing the config is a good idea, as a config is usually easier to +1 than a huge pile of code that we can't test ourselves. > 2) Do I need do some extra steps to loaded my code into main repository Maintainers take care of merging in Gerrit. Unless there occur conflicts, e.g., between your psoc6 and my psoc5lp driver, in which case you may be asked to rebase. > and generate msi or setup file (We want to send link on Open OCD to our > customers)? That's a different question. Releases are rather far apart, so other vendors build and host their own binaries with or without patches on top - in that case you must ensure to also make the source code available alongside the binaries. As a Linux user I don't know whether someone builds nightly Windows binaries for you - since the 0.10.0 release was just recently, we're unlikely to get a 0.11.0 so soon. Regards, Andreas P.S. No need to repeat your questions you posted. Also if you need to ping a question, please do so as a real (threaded) reply. -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) |