|
From: Andreas F. <afa...@su...> - 2017-03-16 06:47:43
|
Hi, Am 15.03.2017 um 18:01 schrieb Mykhaylo Lyubun: > Which step need execute to load changed code in code review which are executed? You need to fix the original commit, not add new commits with fix-ups but same non-telling commit message. The Change-Id line needs to remain the same for Gerrit to associate different commits as updates of the same patch. See git commit --amend or git rebase -i. Also, you should really create your own account - you can still push new versions of the patchset using your own login. Note that if you make changes they needs to carry your Signed-off-by too, not just your colleague's. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) |