[OpenOCD-devel] Kinetis patches

[Tomas V. <to...@us...>]

Hi Steven,

is there any chance you do a review?
Especially
http://openocd.zylin.com/3925
might be interesting for you as it addresses flash banks creation we 
discussed earlier.

Of course if somebody other is interested, please do not hesitate to  
review any of

http://openocd.zylin.com/3896 flash Kinetis: add KE1xZ and KE1xF families
http://openocd.zylin.com/3898 flash Kinetis: add KL8x family, fix erase 
check
http://openocd.zylin.com/3900 flash Kinetis: add KV5x family
http://openocd.zylin.com/3901 flash Kinetis: handle all types of 
watchdog, disable in reset-init
http://openocd.zylin.com/3924 flash Kinetis: split kinetis_chip from 
kinetis_flash_bank
http://openocd.zylin.com/3925 flash Kinetis: implement automatic bank 
creation based on device probe

Thanks
     Tom

On 09.11.2016 23:41, Steven Stallion (Code Review) wrote:
> Steven Stallion has posted comments on this change.
>
> Change subject: k21.cfg: add target for Kinetis K21
> ......................................................................
>
>
> Patch Set 3:
>
>>>> Moreover K21 has two flash banks. The second one is either
>   > pflash
>   > > > or NVM and specific config should define it as kx.cfg does not.
>   > > (I
>   > > > bet the same problem is in historic k40.cfg and k60.cfg)
>   > >
>   > > It depends. Not all models of the K21F support multiple banks. I
>   > > believe the MK21FN5121MN0 only has one.
>   >
>   > Oh yes. So do we need two different configs for K21, don't we?
>   >
>   > > > And the last but not least: do we really want to have configs
>   > for
>   > > > every Kinetis MCU type: K02, K10, K11, K12, K20, K21, K22, K24,
>   > > > K26, K30, K40, K60, K61, K63, K64, K65, K66, K70, K80, K81, K82
>   > > and
>   > > > more in KL, KV families?
>   > >
>   > > This is a good question - I had the same thought. I think if we
>   > > aren't going to provide a cfg for each chip, we should probably
>   > do
>   > > away with K40 and K60 as well and just rely on kx.cfg.
>   >
>   > Kind of... I have an idea of extending kinetis.c with tcl command
>   > to tell what banks the autodetected MCU has. Universal kx.cfg would
>   > define what is appropriate then. Unfortunately I'm short of time so
>   > I'm happy to define what I need in openocd.cfg
>   > Until a working solution to bank definition problem is ready I
>   > wouldn't touch the old cfgs.
>   
> Fair enough. I'll abandon this change then and just use a k21.cfg locally until we can come up with a better solution. Thanks!
>