[OpenOCD-devel] [PATCH]: 8b070a1 aarch64: fix cache identification

[<ge...@op...>]

This is an automated email from Gerrit.

Matthias Welwarsky (mat...@we...) just uploaded a new patch set to Gerrit, which you can find at http://openocd.zylin.com/3753

-- gerrit

commit 8b070a1ad6bead47cce27e9bd90381aceca01740
Author: Matthias Welwarsky <mat...@sy...>
Date:   Fri Sep 16 11:49:57 2016 +0200

    aarch64: fix cache identification
    
    Use correct instructions to access CLIDR, CSSELR and CCSIDR.
    
    Change-Id: I319b96c03a44fdb59fcb18a00f816f6af0261f0a
    Signed-off-by: Matthias Welwarsky <mat...@sy...>

diff --git a/src/target/aarch64.c b/src/target/aarch64.c
index e0d2b9a..74a451c 100644
--- a/src/target/aarch64.c
+++ b/src/target/aarch64.c
@@ -1235,10 +1235,8 @@ static int aarch64_post_debug_entry(struct target *target)
 	LOG_DEBUG("System_register: %8.8" PRIx32, aarch64->system_control_reg);
 	aarch64->system_control_reg_curr = aarch64->system_control_reg;
 
-#if 0
 	if (armv8->armv8_mmu.armv8_cache.ctype == -1)
 		armv8_identify_cache(target);
-#endif
 
 	armv8->armv8_mmu.mmu_enabled =
 			(aarch64->system_control_reg & 0x1U) ? 1 : 0;
diff --git a/src/target/armv8.c b/src/target/armv8.c
index 355a0ee..57e256b 100644
--- a/src/target/armv8.c
+++ b/src/target/armv8.c
@@ -640,23 +640,22 @@ done:
 
 int armv8_identify_cache(struct target *target)
 {
-	/*  read cache descriptor */
+	/*	read cache descriptor */
 	int retval = ERROR_FAIL;
 	struct armv8_common *armv8 = target_to_armv8(target);
 	struct arm_dpm *dpm = armv8->arm.dpm;
 	uint32_t cache_selected, clidr;
 	uint32_t cache_i_reg, cache_d_reg;
 	struct armv8_cache_common *cache = &(armv8->armv8_mmu.armv8_cache);
-	if (!armv8->is_armv7r)
-		armv8_read_ttbcr(target);
+	armv8_read_ttbcr(target);
 	retval = dpm->prepare(dpm);
 
 	if (retval != ERROR_OK)
 		goto done;
-	/*  retrieve CLIDR
-	 *  mrc	p15, 1, r0, c0, c0, 1		@ read clidr */
+	/*	retrieve CLIDR
+	 *	mrc p15, 1, r0, c0, c0, 1		@ read clidr */
 	retval = dpm->instr_read_data_r0(dpm,
-			ARMV4_5_MRC(15, 1, 0, 0, 0, 1),
+			ARMV8_MRS(SYSTEM_CLIDR, 0),
 			&clidr);
 	if (retval != ERROR_OK)
 		goto done;
@@ -664,58 +663,51 @@ int armv8_identify_cache(struct target *target)
 	LOG_INFO("number of cache level %" PRIx32, (uint32_t)(clidr / 2));
 	if ((clidr / 2) > 1) {
 		/* FIXME not supported present in cortex A8 and later */
-		/*  in cortex A7, A15 */
+		/*	in cortex A7, A15 */
 		LOG_ERROR("cache l2 present :not supported");
 	}
-	/*  retrieve selected cache
-	 *  MRC p15, 2,<Rd>, c0, c0, 0; Read CSSELR */
+	/*	retrieve selected cache*/
 	retval = dpm->instr_read_data_r0(dpm,
-			ARMV4_5_MRC(15, 2, 0, 0, 0, 0),
+			ARMV8_MRS(SYSTEM_CSSELR, 0),
 			&cache_selected);
 	if (retval != ERROR_OK)
 		goto done;
 
-	retval = armv8->arm.mrc(target, 15,
-			2, 0,	/* op1, op2 */
-			0, 0,	/* CRn, CRm */
-			&cache_selected);
-	if (retval != ERROR_OK)
-		goto done;
+
 	/* select instruction cache
-	 *  MCR p15, 2,<Rd>, c0, c0, 0; Write CSSELR
-	 *  [0]  : 1 instruction cache selection , 0 data cache selection */
+	 *	[0]  : 1 instruction cache selection , 0 data cache selection */
 	retval = dpm->instr_write_data_r0(dpm,
-			ARMV4_5_MRC(15, 2, 0, 0, 0, 0),
+			ARMV8_MRS(SYSTEM_CSSELR, 0),
 			1);
 	if (retval != ERROR_OK)
 		goto done;
 
 	/* read CCSIDR
 	 * MRC P15,1,<RT>,C0, C0,0 ;on cortex A9 read CCSIDR
-	 * [2:0] line size  001 eight word per line
+	 * [2:0] line size	001 eight word per line
 	 * [27:13] NumSet 0x7f 16KB, 0xff 32Kbytes, 0x1ff 64Kbytes */
 	retval = dpm->instr_read_data_r0(dpm,
-			ARMV4_5_MRC(15, 1, 0, 0, 0, 0),
+			ARMV8_MRS(SYSTEM_CCSIDR, 0),
 			&cache_i_reg);
 	if (retval != ERROR_OK)
 		goto done;
 
-	/*  select data cache*/
+	/*	select data cache*/
 	retval = dpm->instr_write_data_r0(dpm,
-			ARMV4_5_MRC(15, 2, 0, 0, 0, 0),
+			ARMV8_MRS(SYSTEM_CSSELR, 0),
 			0);
 	if (retval != ERROR_OK)
 		goto done;
 
 	retval = dpm->instr_read_data_r0(dpm,
-			ARMV4_5_MRC(15, 1, 0, 0, 0, 0),
+			ARMV8_MRS(SYSTEM_CCSIDR, 0),
 			&cache_d_reg);
 	if (retval != ERROR_OK)
 		goto done;
 
-	/*  restore selected cache  */
+	/*	restore selected cache	*/
 	dpm->instr_write_data_r0(dpm,
-		ARMV4_5_MRC(15, 2, 0, 0, 0, 0),
+		ARMV8_MRS(SYSTEM_CSSELR, 0),
 		cache_selected);
 
 	if (retval != ERROR_OK)

--