Re: [OpenOCD-user] OpenOCD 0.8.0-rc1 release candidate is out

[Markus M. <lot...@gm...>]

On 03/30/2014 08:39 AM, Paul Fertser wrote:
> Hi,
>
> I'm pleased to announce the first release candidate of the upcoming
> OpenOCD version. The source archives are available from the usual SF
> download locations.
>
>  From now on we're entering a feature freeze stage aimed at producing a
> quality release as soon as possible. That means that everyone is
> encouraged to pay specific attention to:
>
> 1. Build issues;
> 2. Regressions;
> 3. Segfaults;
> 4. Other major bugs.
>
> This doesn't mean one shouldn't send new patches to Gerrit or review
> some new functionality, but it means that merging such work will
> likely be postponed until the final release is ready.
>
> Please post all your feedback to the openocd-devel mailing list. It
> would be nice to hear package maintainers from various distros and
> package repositories as we sincerely want to make their lives easier
> and their users happier.
>
> The RC1 phase might end up being as short as 2 weeks if everything
> goes well; after that either another RC will be announced or a final
> release will get tagged.
>

snip...

I've sent some suggestions to the user-list a while ago. As I got no 
response yet, I repost it to the devel list...



Hi,

I was recently doing some cleanup at the fedora openocd package and run 
into some issues.

- the latest jimtcl (0.75) slightly changed its API. A patch to adapt 
openocd to the new API is attached.

- openocd ships with an udev file (contrib/openocd.udev), but its not 
installed into the required udev directory. Is there any reason for this?

- openocd ships firmware for the ulink (OpenULINK/ulink_firmware.hex). 
What's the license of the firmware? Where can the sources be gatherd from?

- ulink_firmware.hex is installed to /usr/lib/openocd. As this file is 
not meant to be executed on the host system, /usr/share/openocd would be 
a better place.


regards,
    Markus

openocd-jimtcl0_75.patch

--- src/helper/command.c	2013-04-19 23:54:16.000000000 +0200
+++ src/helper/command.c	2014-03-03 16:02:51.091705087 +0100
@@ -368,7 +368,7 @@

  	LOG_DEBUG("registering '%s'...", ocd_name);

-	Jim_CmdProc func = c->handler ? &script_command : &command_unknown;
+	Jim_CmdProc *func = c->handler ? &script_command : &command_unknown;
  	int retval = Jim_CreateCommand(interp, ocd_name, func, c, NULL);
  	free((void *)ocd_name);
  	if (JIM_OK != retval)
--- src/helper/command.h	2013-04-19 23:54:16.000000000 +0200
+++ src/helper/command.h	2014-03-03 15:48:42.128777100 +0100
@@ -168,7 +168,7 @@
  	struct command *parent;
  	struct command *children;
  	command_handler_t handler;
-	Jim_CmdProc jim_handler;
+	Jim_CmdProc *jim_handler;
  	void *jim_handler_data;
  	enum command_mode mode;
  	struct command *next;
@@ -204,7 +204,7 @@
  struct command_registration {
  	const char *name;
  	command_handler_t handler;
-	Jim_CmdProc jim_handler;
+	Jim_CmdProc *jim_handler;
  	void *jim_handler_data;
  	enum command_mode mode;
  	const char *help;