Re: [Openocd-development] [PATCH] Update ep93xx and at91rm9200 drivers

[Hector O. <hec...@gm...>]

Hello Luca,

I have also been playing with this bug. Just one comment on the ep93xx.c

> diff --git a/src/jtag/drivers/ep93xx.c b/src/jtag/drivers/ep93xx.c
> index 0959a56..09312c5 100644
> --- a/src/jtag/drivers/ep93xx.c
> +++ b/src/jtag/drivers/ep93xx.c
> @@ -47,7 +47,6 @@ static void ep93xx_write(int tck, int tms, int tdi);
>  static void ep93xx_reset(int trst, int srst);
>
>  static int ep93xx_speed(int speed);
> -static int ep93xx_register_commands(struct command_context *cmd_ctx);
>  static int ep93xx_init(void);
>  static int ep93xx_quit(void);
>
> @@ -61,7 +60,6 @@ struct jtag_interface ep93xx_interface =
>        .execute_queue = bitbang_execute_queue,
>
>        .speed = ep93xx_speed,
> -       .register_commands = ep93xx_register_commands,

Why not just use the right value in the struct,
+       .commands = ep93xx_register_commands,

Best regards,
:-)
-- 
 Héctor Orón

"Our Sun unleashes tremendous flares expelling hot gas into the Solar
System, which one day will disconnect us."

-- Day DVB-T stop working nicely
Video flare: http://antwrp.gsfc.nasa.gov/apod/ap100510.html