Re: [Openocd-development] [PATCH] add new arm11 option for context aware debugging

[Michael B. <mb...@di...>]

On Tue, Nov 17, 2009 at 17:43, David Brownell <da...@pa...> wrote:
> On Tuesday 17 November 2009, Michael Bruck wrote:
>> > p.s. One thing that needs fixing in this patch:  it
>> >     shares "arm11_asid" between all ARM11 cores.
>> >     This should be a core-specific value.
>>
>>
>> This is the same issue with vcr and other global variables that should
>> be target specific. IMO it makes more sense to add this Context ID
>> functionality now and fix the variable scope in a separate patch that
>> addresses all cases.
>
> I don't see that.  Why not fix the variable scope before committing
> something with such a known problem?  It's not difficult to fix it
> before merging ...
>
>
>> A good opportunity for the latter would be when
>> Tcl objects are added and these functions become methods of target
>> objects.
>
> That doesn't seem like such a good opportunity; it's off in the vague
> future.  I'd rather just prevent trivially obvious wrongness from
> getting merged in the first place.


It is functional as it is and can be of use to users. It may be a
problem in multi-core systems, but that is merely a restriction and
doesn't make it unusable. Nothing prevents you from providing a patch
that includes the restructuring that you want.


Michael