Re: [Openocd-development] [PATCH] add new arm11 option for context aware debugging

[David B. <da...@pa...>]

On Tuesday 17 November 2009, Michael Bruck wrote:
> > p.s. One thing that needs fixing in this patch:  it
> >     shares "arm11_asid" between all ARM11 cores.
> >     This should be a core-specific value.
> 
> 
> This is the same issue with vcr and other global variables that should
> be target specific. IMO it makes more sense to add this Context ID
> functionality now and fix the variable scope in a separate patch that
> addresses all cases.

I don't see that.  Why not fix the variable scope before committing
something with such a known problem?  It's not difficult to fix it
before merging ... 


> A good opportunity for the latter would be when 
> Tcl objects are added and these functions become methods of target
> objects.

That doesn't seem like such a good opportunity; it's off in the vague
future.  I'd rather just prevent trivially obvious wrongness from
getting merged in the first place.