Re: [Openocd-development] comments on r161

[Dominic R. <Dom...@gm...>]

Hello Vincent,

I applied the patches without problems, the only change I made was removing 
the "static" keywords from two functions, because this isn't used anywhere 
else in the OpenOCD code. The code uses descriptive names and doesn't easily 
risk collisions.

I have no idea why the stuff from image.[ch] wasn't applied.
The configure.in is missing because I checked in from ./src/ instead of 
top-level.

Thanks for noticing this.

(Re-)Applied, and will be commited with my current changes.

Regards,

Dominic

On Thursday 31 May 2007 17:40:32 Vincent Palatin wrote:
> Hi Dominic,
>
> You have not integrated some details of my previous patches and I don't
> understand really why, could you enlight me ?
>
> here the details :
>
> The 2 last chunks of ihex_update.patch are missing,
> but "section_pointer" field is no longer used since it is replaced by the
> "private" field.
>
> =======  ihex_update.patch  =========
> --- src/target/image.c  2007-05-31 09:03:00.451413560 +0200
> +++ src/target/image.c  2007-05-31 09:28:07.158359288 +0200
> @@ -497,9 +493,6 @@
>
>                 fileio_close(&image_ihex->fileio);
>
> -               if (image_ihex->section_pointer)
> -                       free(image_ihex->section_pointer);
> -
>                 if (image_ihex->buffer)
>                         free(image_ihex->buffer);
>         }
> --- src/target/image.h  2007-05-31 08:15:20.812144808 +0200
> +++ src/target/image.h  2007-05-31 09:25:38.351981296 +0200
> @@ -69,7 +69,6 @@
>  {
>         fileio_t fileio;
>         u8 *buffer;
> -       u8 **section_pointer;
>  } image_ihex_t;
> ============================
>
> In elf_support.patch, the configure.in part is missing,
> but AFAIK it is necessary to define HAVE_SYS_PARAM_H used in replacements.h
> (I might be totally wrong on this point since I'm far from being autotools
> expert)
>
> =======  elf_support.patch  =========
> --- configure.in        (révision 160)
> +++ configure.in        (copie de travail)
> @@ -4,6 +4,8 @@
>
>  AC_CANONICAL_HOST
>
> +AC_CHECK_HEADERS(sys/param.h)
> +
>  AC_C_BIGENDIAN
>
>  AC_CHECK_FUNCS(strndup)
> ============================