From: DJ G. <dj...@op...> - 2007-12-24 23:24:16
|
There are four event configuration files in $OPENNMS_HOME/etc/events in trunk that are not included in $OPENNMS_HOME/etc/eventconf.xml: AirDefense.events.xml CIM.events.xml DPS.events.xml K5Systems.events.xml Should these be removed? Should they be added to eventconf.xml? If they should be kept around but not used by default, should they be moved to etc/examples/events if they aren't enabled by default? If I don't hear a response in a few days, I'll remove them and enable the new test that caught this. FWIW, here are links to those files: http://opennms.svn.sourceforge.net/viewvc/opennms/opennms/trunk/opennms-daemon/src/main/filtered/etc/eventconf.xml?view=markup http://opennms.svn.sourceforge.net/viewvc/opennms/opennms/trunk/opennms-daemon/src/main/filtered/etc/events/AirDefense.events.xml?view=markup http://opennms.svn.sourceforge.net/viewvc/opennms/opennms/trunk/opennms-daemon/src/main/filtered/etc/events/CIM.events.xml?view=markup http://opennms.svn.sourceforge.net/viewvc/opennms/opennms/trunk/opennms-daemon/src/main/filtered/etc/events/DPS.events.xml?view=markup http://opennms.svn.sourceforge.net/viewvc/opennms/opennms/trunk/opennms-daemon/src/main/filtered/etc/events/K5Systems.events.xml?view=markup - djg PS: I noticed this when I added a unit test that checked for this (and another condition) and saw it fail. It is DISABLEDtestIncludedEventFilesExistAndNoExtras in org.opennms.netmgt.eventd.EventConfigurationManagerTest. |