Re: [Openipmi-developer] [PATCH v1] ipmi:ssif: Drop unused assignment of platform_device_id driver data

[Corey M. <co...@mi...>]

On Fri, May 29, 2026 at 01:03:39PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The driver explicitly set the .driver_data member of struct
> platform_device_id to zero without relying on that value. Drop this
> unused assignments.
> 
> While touching this array use a named initializer for assigning .name.

Sure, this is fine, it's in my next tree.

-corey

> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.k...@ba...>
> ---
> Hello,
> 
> this patch is a preparation for changing struct platform_device_id
> see e.g.
> https://lore.kernel.org/all/cov...@ba.../
> for the details about the quest.
> 
> Best regards
> Uwe
> 
>  drivers/char/ipmi/ipmi_ssif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index add043b812ea..07f1d2327bb7 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -2127,7 +2127,7 @@ static void ssif_platform_remove(struct platform_device *dev)
>  }
>  
>  static const struct platform_device_id ssif_plat_ids[] = {
> -    { "dmi-ipmi-ssif", 0 },
> +    { .name = "dmi-ipmi-ssif" },
>      { }
>  };
>  MODULE_DEVICE_TABLE(platform, ssif_plat_ids);
> 
> base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad
> -- 
> 2.47.3
>