Re: [Openipmi-developer] [PATCH] ipmi:ssif: Improve detecting during probing

[Corey M. <co...@mi...>]

On Tue, Sep 10, 2024 at 5:19 AM Ivan T. Ivanov <ii...@su...> wrote:
>
> Hi Corey,
>
> On 08-20 20:05, Corey Minyard wrote:
> >
> > If an IPMI SSIF device is probed and there is something there, but
> > probably not an actual BMC, the code would just issue a lot of errors
> > before it failed.  We kind of need these errors to help with certain
> > issues, and some of the failure reports are non-fatal.
> >
> > However, a get device id command should alway work.  If that fails,
> > nothing else is going to work and it's a pretty good indication that
> > there's no valid BMC there.  So issue and check that command and bail
> > if it fails.
> >
> > Reported-by: Ivan T. Ivanov <ii...@su...>
> > Signed-off-by: Corey Minyard <co...@mi...>
> > ---
> >  drivers/char/ipmi/ipmi_ssif.c | 24 +++++++++++++++++++++++-
> >  1 file changed, 23 insertions(+), 1 deletion(-)
>
> Do you plan to merge this fix?

Yes, it's queued for the next release window.  I should have responded
with that.

-corey

>
> Regards,
> Ivan
>