Re: [Openipmi-developer] [PATCH] ipmi:ssif: Improve detecting during probing
Brought to you by:
cminyard
|
From: Ivan T. I. <ii...@su...> - 2024-09-10 10:19:58
|
Hi Corey, On 08-20 20:05, Corey Minyard wrote: > > If an IPMI SSIF device is probed and there is something there, but > probably not an actual BMC, the code would just issue a lot of errors > before it failed. We kind of need these errors to help with certain > issues, and some of the failure reports are non-fatal. > > However, a get device id command should alway work. If that fails, > nothing else is going to work and it's a pretty good indication that > there's no valid BMC there. So issue and check that command and bail > if it fails. > > Reported-by: Ivan T. Ivanov <ii...@su...> > Signed-off-by: Corey Minyard <co...@mi...> > --- > drivers/char/ipmi/ipmi_ssif.c | 24 +++++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) Do you plan to merge this fix? Regards, Ivan |