Re: [Openipmi-developer] [PATCH] ipmi:ssif: Exit early when there is a SMBus error

[Ivan T. I. <ii...@su...>]

On 08-18 12:27, Ivan T. Ivanov wrote:
> 
> > 
> > 3) It appears the response to the GET_DEVICE_ID command, though a
> > response is returned, is not valid.  The right way to handle this would
> > be to do more validation in the ssif_detect() function.  It doesn't do
> > any validation of the response data, and that's really what needs to be
> > done.
> > 
> 
> do_cmd() in ssif_detect() already do validation. Perhaps,
> ssif_probe() should just not return ENODEV in case of error.
> 

Oh, I wanted to say ssif_detect, not ssif_probe. 

Regards,
Ivan