Re: [Openipmi-developer] [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings

[Wang, H. <hai...@li...>]

在 2019-07-26 13:39, Andrew Jeffery 写道:
> The v2 bindings allow us to extract the resources from the devicetree.
> The table in the driver is retained to derive the channel index, which
> removes the need for kcs_chan property from the v1 bindings. The v2
> bindings allow us to reduce the number of warnings generated by the
> existing devicetree nodes.
>
> Cc: Haiyue Wang<hai...@li...>
> Cc: Corey Minyard<mi...@ac...>
> Cc: Arnd Bergmann<ar...@ar...>
> Cc: Greg Kroah-Hartman<gr...@li...>
> Cc:ope...@li...
> Signed-off-by: Andrew Jeffery<an...@aj...>
> ---
>   drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------
>   1 file changed, 127 insertions(+), 29 deletions(-)

Looks good, thanks for the hard work, the code is more clean! :)

Reviewed-by: Haiyue Wang <hai...@li...>