Re: [Openipmi-developer] [RFC PATCH 14/17] ipmi: kcs: Finish configuring ASPEED KCS device before enable

[Wang, H. <hai...@li...>]

在 2019-07-26 13:39, Andrew Jeffery 写道:
> The currently interrupts are configured after the channel was enabled.
>
> Cc: Haiyue Wang<hai...@li...>
> Cc: Corey Minyard<mi...@ac...>
> Cc: Arnd Bergmann<ar...@ar...>
> Cc: Greg Kroah-Hartman<gr...@li...>
> Cc:ope...@li...
> Signed-off-by: Andrew Jeffery<an...@aj...>
> ---
>   drivers/char/ipmi/kcs_bmc_aspeed.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
> index 3c955946e647..e3dd09022589 100644
> --- a/drivers/char/ipmi/kcs_bmc_aspeed.c
> +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
> @@ -268,13 +268,14 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
>   	kcs_bmc->io_inputb = aspeed_kcs_inb;
>   	kcs_bmc->io_outputb = aspeed_kcs_outb;
>   
> +	rc = aspeed_kcs_config_irq(kcs_bmc, pdev);
> +	if (rc)
> +		return rc;
> +
>   	dev_set_drvdata(dev, kcs_bmc);


Thanks for catching this, for not miss the data.