Re: [Opencryptoki-tech] [PATCH 1/1] remove md2 in rsa_sign_test

[Klaus H. K. <kl...@li...>]

On Fri, 8 Oct 2010 10:45:35 -0500
Kent Yoder <ke...@li...> wrote:

> 
>   The header file for MD2 has disappeared in openssl-1.0, breaking the
> build when it hits rsa_sign_test.  It looks like MD2 is fairly
> irrelevant -- all but 2 of the tokens define NOMD2 explicitly, the other
> 2 don't use it and should probably define NOMD2 themselves. This patch
> just removes the MD2 portion of rsa_sign_test so that the test can
> build.
> 

Interesting, thanks for bringing this up Kent.

Since OpenSSL retired MD2, do you think we should be drawing a
roadmap to do the same?

I have the impression that none of our supported tokens does MD2 in
hardware anyway.

 -Klaus

> Kent
> 
> Signed-off-by: Kent Yoder <ke...@li...>
> 
> diff --git a/testcases/rsa_test/rsa_sign_test.c b/testcases/rsa_test/rsa_sign_test.c
> index 751bf93..0f97e0c 100644
> --- a/testcases/rsa_test/rsa_sign_test.c
> +++ b/testcases/rsa_test/rsa_sign_test.c
> @@ -47,7 +47,6 @@
> 
>  #include <openssl/evp.h>
>  #include <openssl/sha.h>
> -#include <openssl/md2.h>
>  #include <openssl/md4.h>
>  #include <openssl/md5.h>
>  #include <openssl/rsa.h>
> @@ -81,10 +80,6 @@ do_OpenSSLVerify(CK_SESSION_HANDLE session, CK_BYTE *signature,
>  	EVP_MD *nid_alg = NULL;
> 
>  	switch (nid) {
> -		case NID_md2:
> -			ihash_len = MD2_DIGEST_LENGTH;
> -			nid_alg = (EVP_MD *)EVP_md2();
> -			break;
>  		case NID_md5:
>  			ihash_len = MD5_DIGEST_LENGTH;
>  			nid_alg = (EVP_MD *)EVP_md5();
> @@ -211,10 +206,6 @@ do_SignVerALG_RSA_PKCS(CK_SESSION_HANDLE session, CK_OBJECT_HANDLE publ_key,
>  		   nid = NID_sha1;
>  		   alg_string = "SHA-1";
>  		   break;
> -	   case CKM_MD2_RSA_PKCS:
> -		   nid = NID_md2;
> -		   alg_string = "MD2";
> -		   break;
>  	   case CKM_MD5_RSA_PKCS:
>  		   nid = NID_md5;
>  		   alg_string = "MD5";
> 
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
> Spend less time writing and  rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> _______________________________________________
> Opencryptoki-tech mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opencryptoki-tech



-- 
Klaus Heinrich Kiwi | kl...@br... | http://blog.klauskiwi.com
Open Source Security blog : 	http://www.ratliff.net/blog
IBM Linux Technology Center :	http://www.ibm.com/linux/ltc