From: Lee P. <le...@sa...> - 2007-12-11 19:27:05
|
Rick, I'd be more than happy to assist and should have a Windows system that I can install the latest build on. However, I think we need to be cautious and not simply change the testGroup to match the returned error. In other words, the new error needs to be verified that it is the correct one for the syntax being generated. Lee Rick McGuire wrote: > I'm pretty close to checking in a very massive change that does a lot of > internal cleanup on the use of numbers throughout the interpreter. I'm > getting quite a few test failures currently, but all of the failures > I've looked at so far are the result of changes in the specific error > conditions that get issued for different situations. Here's a typical > failure: > > ::method "test_at_syntax1" > > a=.array~new > self~expectSyntax("93.938") > a~at(.nil) > > The error 93.938 is a very generic one that's sort of in the cascade of > checks that get performed on the argument. The message is: > > Oooops ! ... try again. Incorrect call to method > Method argument 1 must have a string value > > The new error is: > > Oooops ! ... try again. Incorrect call to method > Method argument 1 must be a positive whole > number; found "The NIL object" > > Both are equally correct, but the second does a better job of explaining > what is needed and also > shows what was found. > > If everybody's ok with this, I'd like to check these changes in as soon > as I'm happy with them, then do a divide-and-conquer number on the > tests, either adjusting the expected result or opening bug reports if > it's a real bug. I'd really like to get this change committed soon, > since it represents a significant cleanup in the code. > > Rick > > > > > > > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > SF.Net email is sponsored by: > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > > > ------------------------------------------------------------------------ > > _______________________________________________ > Oorexx-devel mailing list > Oor...@li... > https://lists.sourceforge.net/lists/listinfo/oorexx-devel |