From: <mie...@us...> - 2011-02-08 01:25:41
|
Revision: 6721 http://oorexx.svn.sourceforge.net/oorexx/?rev=6721&view=rev Author: miesfeld Date: 2011-02-08 01:25:35 +0000 (Tue, 08 Feb 2011) Log Message: ----------- ooDialog - fix the return from ListBox::delete() Modified Paths: -------------- main/trunk/extensions/platform/windows/oodialog/DialogControls.cls main/trunk/extensions/platform/windows/oodialog/oodMessaging.cpp Modified: main/trunk/extensions/platform/windows/oodialog/DialogControls.cls =================================================================== --- main/trunk/extensions/platform/windows/oodialog/DialogControls.cls 2011-02-08 00:39:44 UTC (rev 6720) +++ main/trunk/extensions/platform/windows/oodialog/DialogControls.cls 2011-02-08 01:25:35 UTC (rev 6721) @@ -463,7 +463,7 @@ ::method delete unguarded use strict arg index = (self~selectedIndex) - if index == 0 then return 0 + if index == 0 then return -1 return self~sendWinIntMsg(self~LB_DELETESTRING, index - 1, 0) ::method deleteAll unguarded Modified: main/trunk/extensions/platform/windows/oodialog/oodMessaging.cpp =================================================================== --- main/trunk/extensions/platform/windows/oodialog/oodMessaging.cpp 2011-02-08 00:39:44 UTC (rev 6720) +++ main/trunk/extensions/platform/windows/oodialog/oodMessaging.cpp 2011-02-08 01:25:35 UTC (rev 6721) @@ -2137,9 +2137,14 @@ * allocation error. * * @remarks The command message table is allocated during the plain base dialog - * init process, so we do not need to check that it has been - * allocated. TODO TODO this statement is not true think testListbox.rex + * init process, so we should not need to check that it has been + * allocated. However, there are some errors the programmer can make + * that can cause us, rarely, to get here with commandMsgs not + * allocated. Better to check and raise a condition for this + * situation. * + * TODO - We need a context here to raise a condition. + * * Caller must ensure that 'prog' is not an empty string and that * winMsg, wParam, lParam are not all 0. TODO need to recheck this. */ This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |