From: Rainer T. <ta...@ta...> - 2008-10-21 20:04:46
|
Hello, Rick McGuire wrote: > On Tue, Oct 21, 2008 at 3:35 PM, Rainer Tammer <ta...@ta...> wrote: > >> Hello, >> >> Rick McGuire wrote: >> >>> Rainer, please open a Patch tracker item for your changes an submit an >>> SVN generated DIFF as the patch. >>> > Well, assuming you did an svn checkout to get the code in the first > place, all you need do to generate a patch is > > Yes, cut and past is your friend :-)) > "svn diff > mypatch.diff" > > OK, the I have to do some magic... as the build machine has no Internet connection which is suitable for svn I have to transfer the code to a other machine... This will take a bit. >> >> Should I try to put this in the autoconf or should I use the _AIX for >> the moment ?? >> > > Just submit the patch with the changes you think are necessary. > Before we commit the changes to the code, we'll figure out how it > needs to be done. > > OK > >>>> 3. commented out some pieces which have bot been updated in rexxutil.cpp >>>> >>>> Are this utility functions no longer needed ?? >>>> What is the replacement for this functions ?? >>>> >>>> >>>> >> Is there a quick explanation why this functionality is abandoned ?? >> Do we need to get this functions working on AIX or are they no longer >> needed ?? >> > > These functions are completely undocumented (not even in the code), so > it's difficult to see us being able to maintain these in the future, > particularly for newer 64-bit platforms. They appear to be for > compatibility with an older Classic AIX Rexx version, so I have no > idea how much those are still being used. I don't even have a sense > as to how many people are even using ooRexx on AIX currently. This is really hard to say. I think many people still have old stuff from teh z/XX machines. > My > first guess is to just disable those functions entirely for now, since > we don't really know how the packages they're trying to load are > defined. > > OK, so we could change the define from AIX to AIX_LEGACY_DISABLED or something like that. > Rick > > Bye Rainer |