OmegaT - multiplatform CAT tool / Feature Requests / #938 XLIFF filter: Ignore type and ctype attributes when building <ph> tag shortcuts

#938 XLIFF filter: Ignore type and ctype attributes when building <ph> tag shortcuts

Milestone: 3.0

Status: closed-fixed

Owner: cienislaw

Labels: tmx (3) xliff (2) ttx (1)

Priority: 5

Updated: 2014-01-23

Created: 2013-12-19

Creator: cienislaw

Private: No

Lately friend needed to do proofreading of TTX file. after playing with Okapi Filters, I've decided to use Okapi Rainbow to TTX->XLIFF and TTX->TMX conversions. XLIFF in source, TMX in tmx/auto and result wasn't as expected. There was difference in PH tags handling in XLIFF and TMX filter. This patch resolves this issue - XLIFF filter generates shortcuts for PH tags the same as TMX filter does ie it does not take in account value of type and ctype attributes. For compatibility I've added it as option in XLIFF filter.

I did not use Netbeans to reedit EditXLIFFOptionsDialog.form so probably it should be recreated by hand. The same goes for EditXLIFFOptionsDialog.java. If needed I can do this properly, just need to install Netbeans.

Please let me know if you have any questions/suggestions.

1 Attachments

Discussion

Didier Briel - 2013-12-20

TMX filter does ie it does not take in account value of type and ctype attributes

The TMX filter can take into account type. E.g., <ph type="w:commentRangeStart" x="2"/>
See
inlineTagHandler.setOtherTagShortcutLetter(StringUtil.getFirstLetterLowercase(getAttributeValue(eStart,"type"))); in TMXReader2.

I understand the need, but the title of the request and the label and variable names should be changed to better reflect the situation.

Also, if possible please use NetBeans to edit the form.

Didier

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

cienislaw - 2013-12-20

thanx for feedback. what do you suggest for variable names and label? I will edit form properly with NetBeans.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Didier Briel - 2013-12-23

If I understand the patch correctly, you ignore type and ctype to build the shortcut.

So, something like "Ignore type and ctype attributes when building <ph> tag shortcuts" seems better (I have changed the title accordingly).

The variable could be ignoreTypeforPhTags.

Didier

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Didier Briel - 2013-12-23

summary: Generate shortcut for <ph> tags like TMX filter does --> XLIFF filter: Ignore type and ctype attributes when building <ph> tag shortcuts
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

cienislaw - 2013-12-26

refactored and edited with NetBeans.

ignore.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Didier Briel - 2013-12-30

status: open --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Didier Briel - 2013-12-30

Implemented in SVN (/trunk).

I just changed a few variable names for consistency with camel-back notation, and added a label in the dialog to avoid repeating "3.x filter only".

Didier

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Didier Briel - 2014-01-23

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Didier Briel - 2014-01-23

Implemented in the released version 3.0.8 update 2 of OmegaT.

Didier

Last edit: Didier Briel 2014-01-23

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.