Menu

#1208 Sortable and clickable Statistics file list

4.0
closed-fixed
None
8
2016-11-15
2016-03-30
No

Now that there is a nice table for displaying the statistics, I think it would be great to be able to sort the files on the different stats columns. Also, I think we should be able to click on a file to in this window to open it in the Editor (just like the Project/Project File window).

Discussion

  • Briac Pilpré

    Briac Pilpré - 2016-03-30

    Implemented in /trunk.
    The gotoFile method is copied from the ProjectFileListController, it may be better to factorize both ?

     
  • Aaron Madlon-Kay

    1. Please use MouseAdapter instead of MouseListener so you don't have to implement useless methods.
    2. Please revisit the gotoFile method. At the very least this line is useless:
    Core.getProject().getProjectFiles().get(modelRow);
    
     
    • Briac Pilpré

      Briac Pilpré - 2016-03-30

      Thanks for the remarks, I will fix the class as soon as I can.
      Heh, I knew about the MouseAdapter, I just couldn't remember the name of
      the class!

       

      Last edit: Aaron Madlon-Kay 2016-03-30
  • Aaron Madlon-Kay

    Regarding my point #2 above: It turns out this was a braindead way of testing whether the index of the file was valid or not. That should really be done in IEditor.gotoFile() so I refactored it.

     
  • Didier Briel

    Didier Briel - 2016-11-15
    • status: open --> closed-fixed
    • assigned_to: Briac Pilpré
    • Group: future --> 4.0
     
  • Didier Briel

    Didier Briel - 2016-11-15

    I had missed the implementation of this RFE.

    I have documented it in 4.0.

    Didier

     

Log in to post a comment.