Menu

#725 Custom text color used for text in dialogs

3.6
closed-fixed
None
5
2016-03-09
2014-12-20
khagaroth
No

Since my eyes get fatigued fast with a normal color scheme, I set up a custom dark background / light text color scheme. The problem is, that the custom text color is applied to some text in the dialogs and since they use the OS default background color (light gray), the text is now pretty much invisible.

Related

Bugs: #811

Discussion

  • khagaroth

    khagaroth - 2015-02-21

    Added screenshot showing the bug.

     
  • Didier Briel

    Didier Briel - 2015-02-21

    In which dialogs is the custom colour used?

    Didier

     
  • khagaroth

    khagaroth - 2015-02-21

    About, Display Font, File Filters, Segmentation, Editing Behaviour, Tag Validation, Team, External TMX, Saving and Output, Proxy Login, Project Properties. So, basically everywhere, but it's only used for some dialog elements, mainly what would be a STATIC element in Win32 dialogs, don't know how it's named in Java.

     
  • Jean-Christophe Helary

    [adding comments from #761 and closing there]

    JC:
    A number of dialogs inherit from the default colors where they are not expected to:

    (Text color) Labels:
    Properties/Project Files/Statistics/Font/File Filters (& Edit)/Segmentation/Editing Behavior/Tag Processing/Saving and Output/Proxy Login/About/Conflict resolution

    (Background/Text, etc.) Text area:
    Search/Search-Replace/Validate tags/Scripting/External TMX/User's manual/Last Changes/Log

    Aaron:
    The problem is that COLOR_BACKGROUND ("Background") and COLOR_FOREGROUND ("Text") are applied globally via the UIManager instead of just on the specific components we want:

    /* Apply Look and Feel modifications during inital setup and color modifications. / public static void setupLAF() { Color backgroundColor = Styles.EditorColor.COLOR_BACKGROUND.getColor(); Color foregroundColor = Styles.EditorColor.COLOR_FOREGROUND.getColor(); UIManager.put("TextPane.background", backgroundColor); UIManager.put("TextPane.foreground", foregroundColor); UIManager.put("TextPane.caretForeground", foregroundColor); UIManager.put("TextArea.background", backgroundColor); UIManager.put("TextArea.foreground", foregroundColor); UIManager.put("TextArea.caretForeground", foregroundColor); UIManager.put("EditorPane.background", backgroundColor); UIManager.put("EditorPane.foreground", foregroundColor); UIManager.put("EditorPane.caretForeground", foregroundColor); }
    TextAreas and TextPanes are used throughout the UI in places where this color manipulation is not desirable.

     
    • Aaron Madlon-Kay

      I should have added that the code snippet is from org.omegat.util.gui.Styles.

       
  • Jean-Christophe Helary

    I guess that there is no trivial way to fix that ?

     
  • Aaron Madlon-Kay

    • status: open --> open-fixed
    • assigned_to: Aaron Madlon-Kay
    • Group: 3.1 --> 3.6
     
  • Aaron Madlon-Kay

    Fixed in r8026.

     
  • Didier Briel

    Didier Briel - 2016-03-09
    • status: open-fixed --> closed-fixed
     
  • Didier Briel

    Didier Briel - 2016-03-09

    Closed in the released version 3.6.0 of OmegaT.

    Didier

     

Log in to post a comment.