#713 When using Create Current Translated Document, the message should be in the singular

[Kos Ivantsov]

Upon creating current translated document, the message in status bar uses plural and says, "Translated documents created," while it, of course, should be singular. I suspect, it uses plural for error message(s) as well, but I don't know what I need to do to make OmegaT fail at creating translated document and thus check it.

[Didier Briel]

To be sure (your message is not very clear):
Do you complain because the message says "Translated documents created" while you used "Create translated document"?

Didier

[Kos Ivantsov]

I'm not complaining, of course, I'm just saying that when "Create current translated document" is executed, the messages should use singular as there's always only one current/active document, even if there are multiple documents in the project

Kos

Didier Briel didierbr@users.sf.net wrote:

• Priority: 5 --> 1
• Comment:

To be sure (your message is not very clear):
Do you complain because the message says "Translated documents created"
while you used "Create translated document"?

Didier

---

[bugs:#713] Wrong status message when creating current translated
document

Status: open
Group: 3.1
Created: Sat Oct 11, 2014 09:35 PM UTC by Kos Ivantsov
Last Updated: Sat Oct 11, 2014 09:35 PM UTC
Owner: nobody

Upon creating current translated document, the message in status bar
uses plural and says, "Translated documents created," while it, of
course, should be singular. I suspect, it uses plural for error
message(s) as well, but I don't know what I need to do to make OmegaT
fail at creating translated document and thus check it.

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/omegat/bugs/713/

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions/

--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.

[Yu Tang]

Both [Create Translated Documents] and [Create Current Translated Document] menu items finally call same one method.
And that RealProject#compileProject method puts the message to status bar.
The problem is that the method knows nothing about which menu item invoked it.
Technically we can change the current implementation, but I think it is more easy to change the message string, e.g.;
CT_COMPILE_DONE_MX=Translated documents created
to
CT_COMPILE_DONE_MX=Translated document(s) created

Does this make sense?

[Kos Ivantsov]

The problems with (s) is that it will not work with some languages. What if the method included a counter which would increment with each processed
document, and along with that another singular status message to
was added Bundle.properties? After the compilation of translated
document(s) if the the counter == 1, then singular message would show, and if it's >1, the message we have now (plural) will be shown. It's a bit more complicated, but seems logical to me. It will even show proper message for projects with only one file and make these status messages a bit more consistent.

[Yu Tang]

OK, I see your point.
If we have a counter, also we could include a number of compiled files within status message (if someone wants.)

[Didier Briel]

Fixed in SVN (/trunk).

Didier

[Didier Briel]

Fixed in the released version 3.1.7 of OmegaT.

Didier

[Alex Buloichik]

I understand that this bug already fixed, but what about using ChoiseFormat ? See http://docs.oracle.com/javase/7/docs/api/java/text/MessageFormat.html:
form.applyPattern(
"There {0,choice,0#are no files|1#is one file|1<are {0,number,integer} files}.");

[Didier Briel]

It looks interesting, but conditional strings are rarely a good idea for localisation.

Your string seems complex to give to a translator, and we cannot translate the small bits ("there", "are no files", "is one file", "are", "files") separately.

Didier